The_Great_Archive/cryptpad
1
0
Fork 0
mirror of https://github.com/cryptpad/cryptpad.git synced 2026-09-14 11:05:41 +05:00
Code Issues Packages Projects Releases Wiki Activity

more obvious message for duplicated header detection on checkup

Browse Source
This commit is contained in:
ansuz 2023-03-10 14:35:54 +05:30
parent f96492d5b4
commit 95ee95ece7
1 changed files with 30 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

32
www/checkup/main.js
View File

@ -1177,15 +1177,43 @@ define([
});
});
var COMMONLY_DUPLICATED_HEADERS = [
'X-Content-Type-Options',
'Access-Control-Allow-Origin',
'Permissions-Policy',
'X-XSS-Protection',
];
['/', '/blob/placeholder.txt', '/block/placeholder.txt'].forEach(relativeURL => {
assert(function (cb, msg) {
var url = new URL(relativeURL, trimmedUnsafe).href;
Tools.common_xhr(url, xhr => {
var span = h('span', h('p', '// XXX DEBUGGING DUPLICATED HEADERS'));
var duplicated = false;
var pre = [];
COMMONLY_DUPLICATED_HEADERS.forEach(h => {
var value = xhr.getResponseHeader(h);
if (/,/.test(value)) {
pre.push(`${h}: ${value}`);
duplicated = true;
}
});
if (duplicated) {
span.appendChild(h('pre', pre.join('\n')));
}
// none of the headers should include a comma
// as that indicates they are duplicated
if (!duplicated) { return void cb(true); }
msg.appendChild(h('span', [
h('p', '// XXX DEBUGGING DUPLICATED HEADERS'),
h('pre.cp-raw-text', xhr.getAllResponseHeaders()),
]));
cb(false);
cb({
duplicated,
url,
});
});
});
});