From 95ee95ece7346af2a9d1fd63112698e2fbdd82ef Mon Sep 17 00:00:00 2001
From: ansuz <git@ansuz.xyz>
Date: Fri, 10 Mar 2023 14:35:54 +0530
Subject: [PATCH] more obvious message for duplicated header detection on
 checkup

---
 www/checkup/main.js | 32 ++++++++++++++++++++++++++++++--
 1 file changed, 30 insertions(+), 2 deletions(-)

diff --git a/www/checkup/main.js b/www/checkup/main.js
index 2383d1f4b..3f40bd897 100644
--- a/www/checkup/main.js
+++ b/www/checkup/main.js
@@ -1177,15 +1177,43 @@ define([
         });
     });
 
+    var COMMONLY_DUPLICATED_HEADERS = [
+        'X-Content-Type-Options',
+        'Access-Control-Allow-Origin',
+        'Permissions-Policy',
+        'X-XSS-Protection',
+    ];
+
     ['/', '/blob/placeholder.txt', '/block/placeholder.txt'].forEach(relativeURL => {
         assert(function (cb, msg) {
             var url = new URL(relativeURL, trimmedUnsafe).href;
             Tools.common_xhr(url, xhr => {
+                var span = h('span', h('p', '// XXX DEBUGGING DUPLICATED HEADERS'));
+
+                var duplicated = false;
+                var pre = [];
+                COMMONLY_DUPLICATED_HEADERS.forEach(h => {
+                    var value = xhr.getResponseHeader(h);
+                    if (/,/.test(value)) {
+                        pre.push(`${h}: ${value}`);
+                        duplicated = true;
+                    }
+                });
+                if (duplicated) {
+                    span.appendChild(h('pre', pre.join('\n')));
+                }
+
+                // none of the headers should include a comma
+                // as that indicates they are duplicated
+                if (!duplicated) { return void cb(true); }
+
                 msg.appendChild(h('span', [
-                    h('p', '// XXX DEBUGGING DUPLICATED HEADERS'),
                     h('pre.cp-raw-text', xhr.getAllResponseHeaders()),
                 ]));
-                cb(false);
+                cb({
+                    duplicated,
+                    url,
+                });
             });
         });
     });