The_Great_Archive/banana_split
1
0
Fork 0
mirror of https://github.com/paritytech/banana_split.git synced 2026-09-12 11:40:31 +05:00
Code Issues Actions 2 Packages Projects Releases Wiki Activity
178 Commits 17 Branches 2 Tags 6.7 MiB
master
Commit Graph

178 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
Kirill Pimenov
0c77cc4534
fix: correct reprint threshold display and de-duplicate the formula (#124)
Some checks failed
CodeQL / Analyze (javascript) (push) Has been cancelled
Details
End to end test / e2e-test (push) Has been cancelled
Details
Trivy scan / Analyze (push) Has been cancelled
Details
Yarn tests / yarn (push) Has been cancelled
Details 
* fix: correct reprint threshold display and de-duplicate the formula (F5)

Print.vue recomputed the recovery threshold as floor(total/2)+2 and stored
the *total* in a field misleadingly named `requiredShards`. The reprint
sheets therefore overstated how many more QR codes are needed (e.g. total=5
showed "need 4" instead of the correct 3) — misleading during recovery,
though the QR payloads themselves were always untouched.

Root cause: the threshold policy was duplicated. Share.vue computes
floor(total/2)+1; Print.vue re-implemented it and drifted. Extract a single
`defaultThreshold()` helper (src/util/shards.ts) and use it in both, so they
can never disagree again. Rename Print.vue's field to `totalShards` to match
what it actually holds.

Add unit tests for the helper, including the exact F5 case (total=5 -> 3) and
a strict-majority invariant across the whole 3..255 UI range.

* fix: reject fractional shard counts, clamp the remaining-code count

Review follow-ups on the reprint view.

`<input type="number">` only constrains the spinner, not the value: typing
"3.5" (or clearing the box, which `v-model.number` leaves as "") sailed
through the old `>= 3 && <= 255` check and reached defaultThreshold(),
producing fractional totals and remaining counts. Add `step="1"` for the
spinner and gate on a shared `isValidShardCount()` predicate that also
requires a whole number, so the input and the threshold policy keep agreeing
about what a shard count is.

`needMoreShards` compared with `!==`, so scanning more codes than announced
kept the scanner open and drove `remainingCodes` negative. Compare with `<`
and clamp the remainder at 0.

`threshold` returned 0 for "nothing entered yet", a valid-looking value that
could reach ShardInfo's required-shards prop. Return `undefined` instead and
guard the consuming block on it, making the not-yet-entered state explicit.

The `threshold` and validation paths are covered by shards.spec.ts; the
scanner-overshoot clamp is not, as the repo has no component-test harness yet.

* fix: apply the same shard-count validation to the generator

Share.vue's shard-count input had the defect Copilot flagged on Print.vue's:
no `step`, no integer check, and `totalShards` fed straight into
crypto.share() — a fractional count surfaced as an opaque secrets.js error
routed through the generic error hub, and an emptied box passed "" through.

Reuse `isValidShardCount()` and gate the generate button on it, matching the
existing `secretTooLong` pattern (disabled button plus an inline error span),
so both shard-count inputs now agree on what a shard count is.

* fix: stop rendering a threshold derived from an invalid shard count

Gating the generate button left the sentence above it still interpolating
defaultThreshold(totalShards) for values that had just been rejected: an
emptied field coerces to 0 and renders "Will require any 1 shards", and 3.5
renders 2. Give Share.vue's `requiredShards` the same contract as Print.vue's
`threshold` — `undefined` unless the count is usable — show an em dash in the
sentence, and guard both the generated-shards block and crypto.share() on it.

Also strengthen the threshold invariant test. Asserting only
`defaultThreshold(n) > n / 2` does not pin the policy: floor(n/2)+2, the very
formula this branch removed, satisfies it for every even n. Assert the
smallest strict majority instead, which floor(n/2)+1 alone satisfies.
 2026-08-04 16:10:30 +02:00
Kirill Pimenov
11f18074f4
chore: add rel="noopener noreferrer" to the external _blank link (N1) (#125) 
The Wikipedia link in GeneralInfo.vue opened in a new tab without `rel`,
leaving it exposed to reverse-tabnabbing. Negligible in practice (offline
use, trusted URL) but free hygiene. It is the only target="_blank" link in
the app; the other external links open in the same tab.
 2026-08-04 15:56:02 +02:00
dependabot[bot]
61b7f3de8a
Bump elliptic from 6.5.4 to 6.5.7 (#112)
Some checks failed
CodeQL / Analyze (javascript) (push) Has been cancelled
Details
End to end test / e2e-test (push) Has been cancelled
Details
Trivy scan / Analyze (push) Has been cancelled
Details
Yarn tests / yarn (push) Has been cancelled
Details 
Bumps [elliptic](https://github.com/indutny/elliptic) from 6.5.4 to 6.5.7.
- [Commits](https://github.com/indutny/elliptic/compare/v6.5.4...v6.5.7)

---
updated-dependencies:
- dependency-name: elliptic
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
 2024-08-23 11:37:32 +02:00
dependabot[bot]
13c09dff75
Bump gh-pages from 2.2.0 to 5.0.0 (#111) 
Bumps [gh-pages](https://github.com/tschaub/gh-pages) from 2.2.0 to 5.0.0.
- [Release notes](https://github.com/tschaub/gh-pages/releases)
- [Changelog](https://github.com/tschaub/gh-pages/blob/main/changelog.md)
- [Commits](https://github.com/tschaub/gh-pages/compare/v2.2.0...v5.0.0)

---
updated-dependencies:
- dependency-name: gh-pages
  dependency-type: direct:development
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
 2024-08-23 11:37:21 +02:00
dependabot[bot]
217ae42155
Bump minimist from 1.2.5 to 1.2.8 (#104)
Some checks are pending
CodeQL / Analyze (javascript) (push) Waiting to run
Details
End to end test / e2e-test (push) Waiting to run
Details
Trivy scan / Analyze (push) Waiting to run
Details
Yarn tests / yarn (push) Waiting to run
Details 
Bumps [minimist](https://github.com/minimistjs/minimist) from 1.2.5 to 1.2.8.
- [Release notes](https://github.com/minimistjs/minimist/releases)
- [Changelog](https://github.com/minimistjs/minimist/blob/main/CHANGELOG.md)
- [Commits](https://github.com/minimistjs/minimist/compare/v1.2.5...v1.2.8)

---
updated-dependencies:
- dependency-name: minimist
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
 2024-08-22 14:29:40 +02:00
dependabot[bot]
406c7ed76a
Bump express from 4.17.1 to 4.18.2 (#103) 
Bumps [express](https://github.com/expressjs/express) from 4.17.1 to 4.18.2.
- [Release notes](https://github.com/expressjs/express/releases)
- [Changelog](https://github.com/expressjs/express/blob/master/History.md)
- [Commits](https://github.com/expressjs/express/compare/4.17.1...4.18.2)

---
updated-dependencies:
- dependency-name: express
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
 2024-08-22 14:29:30 +02:00
dependabot[bot]
b42dd3a88d
Bump qs from 6.5.2 to 6.5.3 (#102) 
Bumps [qs](https://github.com/ljharb/qs) from 6.5.2 to 6.5.3.
- [Release notes](https://github.com/ljharb/qs/releases)
- [Changelog](https://github.com/ljharb/qs/blob/main/CHANGELOG.md)
- [Commits](https://github.com/ljharb/qs/compare/v6.5.2...v6.5.3)

---
updated-dependencies:
- dependency-name: qs
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
 2024-08-22 14:29:19 +02:00
dependabot[bot]
279bf0ea19
Bump decode-uri-component from 0.2.0 to 0.2.2 (#101) 
Bumps [decode-uri-component](https://github.com/SamVerschueren/decode-uri-component) from 0.2.0 to 0.2.2.
- [Release notes](https://github.com/SamVerschueren/decode-uri-component/releases)
- [Commits](https://github.com/SamVerschueren/decode-uri-component/compare/v0.2.0...v0.2.2)

---
updated-dependencies:
- dependency-name: decode-uri-component
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
 2024-08-22 14:18:30 +02:00
dependabot[bot]
0ca70fa2a7
Bump terser from 4.8.0 to 4.8.1 (#96) 
Bumps [terser](https://github.com/terser/terser) from 4.8.0 to 4.8.1.
- [Release notes](https://github.com/terser/terser/releases)
- [Changelog](https://github.com/terser/terser/blob/master/CHANGELOG.md)
- [Commits](https://github.com/terser/terser/commits)

---
updated-dependencies:
- dependency-name: terser
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
 2024-08-22 14:18:05 +02:00
dependabot[bot]
26790a9958
Bump jpeg-js from 0.4.3 to 0.4.4 (#95) 
Bumps [jpeg-js](https://github.com/eugeneware/jpeg-js) from 0.4.3 to 0.4.4.
- [Release notes](https://github.com/eugeneware/jpeg-js/releases)
- [Commits](https://github.com/eugeneware/jpeg-js/compare/v0.4.3...v0.4.4)

---
updated-dependencies:
- dependency-name: jpeg-js
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
 2024-08-22 14:16:53 +02:00
dependabot[bot]
1d9d1db5aa
Bump protobufjs from 6.11.2 to 6.11.3 (#94) 
Bumps [protobufjs](https://github.com/protobufjs/protobuf.js) from 6.11.2 to 6.11.3.
- [Release notes](https://github.com/protobufjs/protobuf.js/releases)
- [Changelog](https://github.com/protobufjs/protobuf.js/blob/v6.11.3/CHANGELOG.md)
- [Commits](https://github.com/protobufjs/protobuf.js/compare/v6.11.2...v6.11.3)

---
updated-dependencies:
- dependency-name: protobufjs
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
 2024-08-22 14:16:41 +02:00
dependabot[bot]
8395a5f9a2
Bump async from 2.6.3 to 2.6.4 (#92) 
Bumps [async](https://github.com/caolan/async) from 2.6.3 to 2.6.4.
- [Release notes](https://github.com/caolan/async/releases)
- [Changelog](https://github.com/caolan/async/blob/v2.6.4/CHANGELOG.md)
- [Commits](https://github.com/caolan/async/compare/v2.6.3...v2.6.4)

---
updated-dependencies:
- dependency-name: async
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
 2024-08-22 14:16:10 +02:00
dependabot[bot]
61763de28e
Bump url-parse from 1.5.7 to 1.5.10 (#90) 
Bumps [url-parse](https://github.com/unshiftio/url-parse) from 1.5.7 to 1.5.10.
- [Release notes](https://github.com/unshiftio/url-parse/releases)
- [Commits](https://github.com/unshiftio/url-parse/compare/1.5.7...1.5.10)

---
updated-dependencies:
- dependency-name: url-parse
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
 2024-08-22 14:15:44 +02:00
uzeyirdestan
c8d11ea941
Merge pull request #109 from uzeyirdestan/bananasplit-print 
Integration of Bananasplit Export Function with Polkadot Vault
 2024-08-02 01:56:47 +03:00
Uzeyir Destan
d86f1aa422
Removed mismatch check 2024-08-02 01:54:17 +03:00
Uzeyir Destan
376fbe4aa8
Updated import function 2024-08-02 01:54:17 +03:00
Sergejs Kostjucenko
da96cecf56
bump gha versions and add dependabot (#97) 2022-08-26 11:44:16 +07:00
Kirill Pimenov
0ec30f413f
Merge pull request #89 from paritytech/dependabot/npm_and_yarn/node-fetch-2.6.7 
Bump node-fetch from 2.6.6 to 2.6.7
 2022-02-21 13:38:47 +01:00
dependabot[bot]
6b79e73776
Bump url-parse from 1.5.3 to 1.5.7 (#88) 
Bumps [url-parse](https://github.com/unshiftio/url-parse) from 1.5.3 to 1.5.7.
- [Release notes](https://github.com/unshiftio/url-parse/releases)
- [Commits](https://github.com/unshiftio/url-parse/compare/1.5.3...1.5.7)

---
updated-dependencies:
- dependency-name: url-parse
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
 2022-02-19 10:31:41 +07:00
dependabot[bot]
d40efbcc09
Bump node-fetch from 2.6.6 to 2.6.7 
Bumps [node-fetch](https://github.com/node-fetch/node-fetch) from 2.6.6 to 2.6.7.
- [Release notes](https://github.com/node-fetch/node-fetch/releases)
- [Commits](https://github.com/node-fetch/node-fetch/compare/v2.6.6...v2.6.7)

---
updated-dependencies:
- dependency-name: node-fetch
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>
 2022-02-19 03:29:54 +00:00
dependabot[bot]
6a752e56de
Bump follow-redirects from 1.14.5 to 1.14.8 (#87) 
Bumps [follow-redirects](https://github.com/follow-redirects/follow-redirects) from 1.14.5 to 1.14.8.
- [Release notes](https://github.com/follow-redirects/follow-redirects/releases)
- [Commits](https://github.com/follow-redirects/follow-redirects/compare/v1.14.5...v1.14.8)

---
updated-dependencies:
- dependency-name: follow-redirects
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
 2022-02-19 10:29:18 +07:00
Kirill Pimenov
97692cbe02
Updated a typo (#82) 
Well, it is cute in its own way — but we should really try to avoid any typos in that limited text content of BS we have.
One silly joke in the domain name should be more than enough.
 2021-12-31 10:45:07 +07:00
Pavel Rybalko
bc4c9bcac4
always show git hash in bs version (#81) 2021-12-13 15:12:43 +07:00
Pavel Rybalko
2c91c85fb7
Show current version (#80) 
* identify version using Git describe

* fix tests
 2021-12-10 20:32:59 +07:00
Kirill Pimenov
fbf95db158
Merge pull request #78 from paritytech/text-and-css-adjustment 
[UI] Adjust description text and CSS styles
 2021-12-08 12:53:23 +01:00
Pavel Rybalko
282581c0d1
ui: adjust text and styles 
Update src/components/GeneralInfo.vue

Co-authored-by: Kirill Pimenov <kirill@parity.io>
 2021-12-08 18:12:42 +07:00
Pavel Rybalko
3a549409cf
fix #76 add default passphrase canvas width (#77) 
* fix #76 add default passphrase canvas width

* add padLeft constant
 2021-11-17 21:47:32 +07:00
Pavel Rybalko
cbdfc7e08b
add end-to-end UI tests. Resolves #30 
* add 2e2 tests

* fix prettier

* add workflow

* prettify

* update vue/cli-service

* update readme
 2021-11-17 11:21:00 +07:00
Pavel Rybalko
49ee8905e6
Show error messages on UI (#74) 
* fix #63 add error messages on the page

* small changes
 2021-10-19 14:37:31 +07:00
Pavel Rybalko
7aed8b2ea9
fix #33 display ipfs address (#73) 
* fix #33 display ipfs address
* fix styling
 2021-10-07 12:44:20 +07:00
Pavel Rybalko
19bc8b3da7
Merge pull request #70 from paritytech/add-security-scanners 
fix #69 add security scanners
 2021-09-28 19:13:23 +07:00
Pavel Rybalko
8b02568163
Merge pull request #68 from paritytech/migrate-to-typescript 
Migrate to Typescript
 2021-09-28 11:50:47 +07:00
Pavel Rybalko
00c8dd3495
fix #69 add security scanners 2021-09-27 12:53:09 +07:00
Pavel Rybalko
9adb6f9e23
Merge pull request #67 from paritytech/update-readme 
fix #66 update readme
 2021-09-23 21:01:44 +07:00
Pavel Rybalko
99ed55f118
move types to types/vue.d.ts 2021-09-23 15:23:49 +07:00
Pavel Rybalko
c79f43b613
fix #35 migrate to Typescript 2021-09-23 12:00:36 +07:00
Pavel Rybalko
697b435f68
fix #66 update readme 2021-09-22 17:53:28 +07:00
David
77ba6c7939
Merge pull request #54 from paritytech/dependabot/npm_and_yarn/dns-packet-1.3.4 
Bump dns-packet from 1.3.1 to 1.3.4
 2021-09-03 07:19:44 +00:00
dependabot[bot]
46f3d82334
Bump dns-packet from 1.3.1 to 1.3.4 
Bumps [dns-packet](https://github.com/mafintosh/dns-packet) from 1.3.1 to 1.3.4.
- [Release notes](https://github.com/mafintosh/dns-packet/releases)
- [Changelog](https://github.com/mafintosh/dns-packet/blob/master/CHANGELOG.md)
- [Commits](https://github.com/mafintosh/dns-packet/compare/v1.3.1...v1.3.4)

Signed-off-by: dependabot[bot] <support@github.com>
 2021-09-01 13:04:09 +00:00
Niklas Adolfsson
c7974e62a0
Merge pull request #60 from paritytech/dependabot/npm_and_yarn/tar-4.4.19 
Bump tar from 4.4.15 to 4.4.19
 2021-09-01 15:03:33 +02:00
dependabot[bot]
fd92a8d9f4
Bump tar from 4.4.15 to 4.4.19 
Bumps [tar](https://github.com/npm/node-tar) from 4.4.15 to 4.4.19.
- [Release notes](https://github.com/npm/node-tar/releases)
- [Changelog](https://github.com/npm/node-tar/blob/main/CHANGELOG.md)
- [Commits](https://github.com/npm/node-tar/compare/v4.4.15...v4.4.19)

---
updated-dependencies:
- dependency-name: tar
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>
 2021-09-01 04:26:02 +00:00
Niklas Adolfsson
a64e44f9d1
Merge pull request #58 from paritytech/dependabot/npm_and_yarn/ws-5.2.3 
Bump ws from 5.2.2 to 5.2.3
 2021-08-26 20:29:22 +02:00
dependabot[bot]
d4354679f7
Bump ws from 5.2.2 to 5.2.3 
Bumps [ws](https://github.com/websockets/ws) from 5.2.2 to 5.2.3.
- [Release notes](https://github.com/websockets/ws/releases)
- [Commits](https://github.com/websockets/ws/compare/5.2.2...5.2.3)

---
updated-dependencies:
- dependency-name: ws
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>
 2021-08-26 17:24:17 +00:00
David
4f1bcc9faa
Merge pull request #53 from paritytech/dependabot/npm_and_yarn/browserslist-4.16.6 
Bump browserslist from 4.6.4 to 4.16.6
 2021-08-26 17:23:50 +00:00
David
bc1125ab73
Merge pull request #57 from paritytech/dependabot/npm_and_yarn/url-parse-1.5.3 
Bump url-parse from 1.4.7 to 1.5.3
 2021-08-26 17:23:36 +00:00
David
ed0f9708d6
Merge pull request #59 from paritytech/dependabot/npm_and_yarn/color-string-1.6.0 
Bump color-string from 1.5.3 to 1.6.0
 2021-08-26 17:22:49 +00:00
David
fee2f9b69a
Merge pull request #49 from paritytech/dependabot/npm_and_yarn/handlebars-4.7.7 
Bump handlebars from 4.5.3 to 4.7.7
 2021-08-26 17:21:53 +00:00
Niklas Adolfsson
e9c7bccdf6
Merge pull request #56 from paritytech/dependabot/npm_and_yarn/path-parse-1.0.7 
Bump path-parse from 1.0.6 to 1.0.7
 2021-08-11 11:51:19 +02:00
dependabot[bot]
a55de3e101
Bump color-string from 1.5.3 to 1.6.0 
Bumps [color-string](https://github.com/Qix-/color-string) from 1.5.3 to 1.6.0.
- [Release notes](https://github.com/Qix-/color-string/releases)
- [Changelog](https://github.com/Qix-/color-string/blob/master/CHANGELOG.md)
- [Commits](https://github.com/Qix-/color-string/commits/1.6.0)

---
updated-dependencies:
- dependency-name: color-string
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>
 2021-08-11 07:42:40 +00:00
dependabot[bot]
4e8ef1ca02
Bump url-parse from 1.4.7 to 1.5.3 
Bumps [url-parse](https://github.com/unshiftio/url-parse) from 1.4.7 to 1.5.3.
- [Release notes](https://github.com/unshiftio/url-parse/releases)
- [Commits](https://github.com/unshiftio/url-parse/compare/1.4.7...1.5.3)

---
updated-dependencies:
- dependency-name: url-parse
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>
 2021-08-11 07:41:43 +00:00