diff --git a/lib/db_x509super.cpp b/lib/db_x509super.cpp index 7bf9271a..6c87d3dc 100644 --- a/lib/db_x509super.cpp +++ b/lib/db_x509super.cpp @@ -26,7 +26,7 @@ dbheaderList db_x509name::getHeaders() new num_dbheader(HD_subject_hash, false, tr("Subject hash"), tr("Hash to lookup certs in directories")); - foreach(int nid, *MainWindow::dn_nid) + foreach(int nid, distname_nid) h << new nid_dbheader(nid, dbheader::hd_x509name); return h; } diff --git a/lib/oid.cpp b/lib/oid.cpp index a0c6f8b2..a8487f8c 100644 --- a/lib/oid.cpp +++ b/lib/oid.cpp @@ -20,6 +20,9 @@ int first_additional_oid = 0; +NIDlist extkeyuse_nid; +NIDlist distname_nid; + QMap oid_name_clash; QMap oid_lower_map; @@ -129,32 +132,11 @@ static void readOIDs(QString fname) } } -void initOIDs() -{ - QString oids = QString(QDir::separator()) + "oids.txt"; - QString dir = getPrefix(); - - first_additional_oid = OBJ_new_nid(0); - openssl_error(); - for (int i=0; i #include +typedef QList NIDlist; + +extern NIDlist extkeyuse_nid; +extern NIDlist distname_nid; + extern int first_additional_oid; extern QMap oid_name_clash; extern QMap oid_lower_map; -typedef QList NIDlist; /* reads additional OIDs from a file: oid, sn, ln */ void initOIDs(); -/* reads a list of OIDs/SNs from a file and turns them into a QValueList - * of integers, representing the NIDs. Usually to be used by NewX509 for - * the list of ExtendedKeyUsage and Distinguished Name - */ - -NIDlist readNIDlist(QString fname); #endif diff --git a/lib/pki_temp.cpp b/lib/pki_temp.cpp index 2ea0b056..108a9180 100644 --- a/lib/pki_temp.cpp +++ b/lib/pki_temp.cpp @@ -8,6 +8,7 @@ #include "pki_temp.h" #include "func.h" #include "db.h" +#include "oid.h" #include "exception.h" #include "widgets/MainWindow.h" #include @@ -272,11 +273,10 @@ void pki_temp::fromData(const unsigned char *p, db_header_t *head ) static QString old_eKeyUse2QString(int old) { QStringList sl; - NIDlist eku_nid = *MainWindow::eku_nid; - for (int i=0; isetPixmap(QPixmap(":keyImg")); @@ -566,10 +534,6 @@ MainWindow::~MainWindow() ERR_free_strings(); EVP_cleanup(); OBJ_cleanup(); - if (eku_nid) - delete eku_nid; - if (dn_nid) - delete dn_nid; delete dbindex; #ifdef MDEBUG fprintf(stderr, "Memdebug:\n"); diff --git a/widgets/NewX509.cpp b/widgets/NewX509.cpp index 69932f78..26fe91f4 100644 --- a/widgets/NewX509.cpp +++ b/widgets/NewX509.cpp @@ -105,8 +105,7 @@ NewX509::NewX509(QWidget *parent) :QDialog(parent) { int i; - eku_nid = *MainWindow::eku_nid; - dn_nid = *MainWindow::dn_nid; + aia_nid << OBJ_sn2nid("OCSP") << OBJ_sn2nid("caIssuers"); attr_nid << NID_pkcs9_unstructuredName << NID_pkcs9_challengePassword; QStringList keys; @@ -116,7 +115,7 @@ NewX509::NewX509(QWidget *parent) /* temporary storage for creating temporary X509V3_CTX */ ctx_cert = NULL; pkiSource = generated; - foreach(int nid, dn_nid) + foreach(int nid, distname_nid) keys << QString(OBJ_nid2ln(nid)); extDNlist->setKeys(keys); @@ -172,7 +171,7 @@ NewX509::NewX509(QWidget *parent) tempList->insertPkiItems(MainWindow::temps->getAllAndPredefs()); // setup Extended keyusage - foreach(int nid, eku_nid) + foreach(int nid, extkeyuse_nid) ekeyUsage->addItem(OBJ_nid2ln(nid)); // setup Authority Info Access diff --git a/widgets/NewX509.h b/widgets/NewX509.h index 4af43e78..d6f03347 100644 --- a/widgets/NewX509.h +++ b/widgets/NewX509.h @@ -43,8 +43,6 @@ class NewX509: public QDialog, public Ui::NewX509 { Q_OBJECT private: - NIDlist eku_nid; - NIDlist dn_nid; NIDlist aia_nid; NIDlist attr_nid; QList attrEdits; diff --git a/widgets/NewX509_ext.cpp b/widgets/NewX509_ext.cpp index 4a25ac47..227fc752 100644 --- a/widgets/NewX509_ext.cpp +++ b/widgets/NewX509_ext.cpp @@ -90,10 +90,8 @@ x509v3ext NewX509::getEkeyUsage() int rows = ekeyUsage->count(); for (int i=0; iitem(i); - //printf("rows = %d, ekeyUsage = %d, %p\n", rows, i, li); if (ekeyUsage->isItemSelected(ekeyUsage->item(i))) { - cont << QString(OBJ_nid2sn(eku_nid[i])); + cont << QString(OBJ_nid2sn(extkeyuse_nid[i])); } } if (ekuCritical->isChecked() && cont.count() > 0) diff --git a/widgets/Options.cpp b/widgets/Options.cpp index e842e1f0..2cd4d573 100644 --- a/widgets/Options.cpp +++ b/widgets/Options.cpp @@ -9,6 +9,7 @@ #include "Options.h" #include "SearchPkcs11.h" #include "lib/pki_scard.h" +#include "lib/oid.h" #include #include #include @@ -21,7 +22,7 @@ Options::Options(MainWindow *parent) setWindowTitle(XCA_TITLE); setupUi(this); - foreach(int nid, *MainWindow::dn_nid) { + foreach(int nid, distname_nid) { QString n = OBJ_nid2ln(nid); extDNobj->addItem(n); expDNobj->addItem(n);