The_Great_Archive/trilium
1
0
Fork 0
mirror of https://github.com/zadam/trilium.git synced 2026-09-12 19:50:20 +05:00
Code Issues Actions 18 Packages Projects Releases Wiki Activity

chore(flatpak): trim the filterSources comment to the binding constraints

Browse Source 
Greptile flagged the fourteen-line block: the measurements and the rejected
--no-devel narrative belong in the commit body of the change that introduced
the filter, not at the call site.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This commit is contained in:
Elian Doran 2026-09-01 14:09:23 +03:00
parent f16771c918
commit 897aeb6cbc
No known key found for this signature in database
1 changed files with 3 additions and 11 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
scripts/generate-flatpak-sources.mts
View File

@ -59,17 +59,9 @@ export function checkPnpm(packageJson: string) {
}
/**
* Drops the Playwright browser archives (~500 MB). They are only reachable from the e2e
* suites, which the sandbox build never runs, and Playwright's install script -- the one
* reader of this cache -- never executes there either, since the offline store disables
* all lifecycle scripts. `--no-devel` is not the answer: the generator does not support
* it for pnpm lockfile v9, and the build needs the other devDependencies anyway (Vite,
* esbuild and tsx are the build toolchain).
*
* The generator is installed from its master branch, so the checks guard against its
* output drifting: a filter that no longer matches would quietly reship the archives,
* and a collapsed count or missing Electron zip would only fail the flatpak build much
* later, inside the sandbox.
* Drops the Playwright browser archives: nothing in the sandbox build can reach them,
* and the generator supports no `--no-devel` for pnpm lockfile v9. The checks make
* generator output drift fail here instead of inside the network-less flatpak build.
*/
export function filterSources(sources: Source[]): Source[] {
const kept = sources.filter((s) => !s.dest?.startsWith("flatpak-node/cache/ms-playwright"));