The_Great_Archive/libretroshare
1
0
Fork 0
mirror of https://github.com/RetroShare/libretroshare.git synced 2026-09-12 19:50:03 +05:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #7 from jolavillette/fix/jsonapi-pointer-hygiene-for-364

Browse Source 
jsonapi: do not replace rsJsonApi silently, and assign it once
This commit is contained in:
defnax 2026-08-16 21:42:59 +02:00 committed by GitHub
commit f482b3e204
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 9 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
src/rsserver/rsinit.cc
View File

@ -451,6 +451,15 @@ void RsInit::startupWebServices(const RsConfigOptions& conf,bool force_start_jso
JsonApiServer* jas = dynamic_cast<JsonApiServer*>(rsJsonApi);
if(!jas)
{
/* Not reachable today -- rsJsonApi is only ever set to a JsonApiServer,
* here and in the plugin handoff of StartupRetroShare(). Should that
* change, replacing it silently would leave every plugin holding the
* pointer it received in setInterfaces() talking to an abandoned
* object, with no trace of why. */
if(rsJsonApi)
RsErr() << "rsJsonApi is set but is not a JsonApiServer. Replacing "
<< "it: plugins still hold the previous pointer.";
jas = new JsonApiServer();
rsJsonApi = jas;
}
@ -537,8 +546,6 @@ void RsInit::startupWebServices(const RsConfigOptions& conf,bool force_start_jso
}
else
RsInfo() << " Not starting JSON API, since it is currently not required by any service." ;
rsJsonApi = jas;
}
#endif