From a09ea85b4238917e5dfd51580139ceb6720c798e Mon Sep 17 00:00:00 2001 From: jolavillette Date: Sat, 15 Aug 2026 11:39:19 +0200 Subject: [PATCH] ci: install Botan, which rnp needs First run: all three jobs stopped at configure with Could NOT find Botan (missing: BOTAN_LIBRARY BOTAN_INCLUDE_DIR) Botan is not a dependency of libretroshare -- it appears in none of its find_package calls, which is why it was missing from these lists -- but rnp requires it, and rnp is pulled in by FetchContent as soon as RS_RNPLIB is on. The super-project's CIs install it for the same reason. libbotan-2-dev, mingw-w64-ucrt-x86_64-libbotan, botan@2. --- .github/workflows/macos-cmake.yml | 2 +- .github/workflows/ubuntu-cmake.yml | 2 +- .github/workflows/windows-cmake.yml | 1 + 3 files changed, 3 insertions(+), 2 deletions(-) diff --git a/.github/workflows/macos-cmake.yml b/.github/workflows/macos-cmake.yml index 3a289091e..f05e46cd8 100644 --- a/.github/workflows/macos-cmake.yml +++ b/.github/workflows/macos-cmake.yml @@ -49,7 +49,7 @@ jobs: run: > brew install cmake ninja pkg-config - openssl@3 sqlcipher miniupnpc json-c + openssl@3 botan@2 sqlcipher miniupnpc json-c bzip2 zlib doxygen - name: CMake configure diff --git a/.github/workflows/ubuntu-cmake.yml b/.github/workflows/ubuntu-cmake.yml index 06eed484c..789129de5 100644 --- a/.github/workflows/ubuntu-cmake.yml +++ b/.github/workflows/ubuntu-cmake.yml @@ -52,7 +52,7 @@ jobs: sudo apt-get update && sudo apt-get install -y build-essential g++ cmake ninja-build pkg-config git - libssl-dev zlib1g-dev libbz2-dev libjson-c-dev + libssl-dev zlib1g-dev libbz2-dev libjson-c-dev libbotan-2-dev libsqlcipher-dev libminiupnpc-dev doxygen python3 diff --git a/.github/workflows/windows-cmake.yml b/.github/workflows/windows-cmake.yml index 41744af11..2798a7728 100644 --- a/.github/workflows/windows-cmake.yml +++ b/.github/workflows/windows-cmake.yml @@ -60,6 +60,7 @@ jobs: mingw-w64-ucrt-x86_64-python mingw-w64-ucrt-x86_64-doxygen mingw-w64-ucrt-x86_64-openssl + mingw-w64-ucrt-x86_64-libbotan mingw-w64-ucrt-x86_64-sqlcipher mingw-w64-ucrt-x86_64-miniupnpc mingw-w64-ucrt-x86_64-json-c