From 7ea31d7b12c074224df9013776c2d07d14b792ee Mon Sep 17 00:00:00 2001 From: jolavillette Date: Sun, 9 Aug 2026 10:00:03 +0200 Subject: [PATCH] cmake: drop rsthreads.cc and rskbdinput.cc from RS_IMPLEMENTATION_HEADERS Both files were listed twice in src/CMakeLists.txt: once (correctly) in RS_SOURCES, and once again in RS_IMPLEMENTATION_HEADERS right next to their .h namesake -- a copy/paste slip dating back to the initial CMake port (449fcbc3). RS_IMPLEMENTATION_HEADERS does not feed add_library(), so this never caused a duplicate compilation. It is only consumed by the install() loop guarded by RS_LIBRETROSHARE_STANDALONE_INSTALL, which was therefore copying the two .cc files into the installed include directory. Co-Authored-By: Claude Opus 5 (1M context) --- src/CMakeLists.txt | 2 -- 1 file changed, 2 deletions(-) diff --git a/src/CMakeLists.txt b/src/CMakeLists.txt index 11c56b344..d33bf12b3 100644 --- a/src/CMakeLists.txt +++ b/src/CMakeLists.txt @@ -704,7 +704,6 @@ list( util/rsfile.h util/rsinitedptr.h util/rsjson.h - util/rskbdinput.cc util/rskbdinput.h util/rslikelyunlikely.h util/rsmacrosugar.hpp @@ -716,7 +715,6 @@ list( util/rsrecogn.h util/rsstd.h util/rsstring.h - util/rsthreads.cc util/rsthreads.h util/rstickevent.h util/rstime.h