The_Great_Archive/hyprspace
1
0
Fork 0
mirror of https://github.com/hyprspace/hyprspace.git synced 2026-09-12 19:51:07 +05:00
Code Issues Actions Packages Projects Releases Wiki Activity

remove single char test

Browse Source
This commit is contained in:
Max 2026-06-18 23:37:49 +02:00 committed by Roland Urbano
parent 046ae0ae9c
commit 719bacf3b9
1 changed files with 0 additions and 17 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

17
config/idhash_test.go
View File

@ -57,23 +57,6 @@ func Test_MkServiceID_Empty(t *testing.T) {
assert.Equal(t, expected, result, "MkServiceID with empty string should return magic bytes")
}
func Test_MkServiceID_SingleChar(t *testing.T) {
result := MkServiceID("x")
// BUG: Single-character service names collide with the empty string.
// MkServiceID computes `id[i%2] ^= b * byte(i)`, so for i=0 the contribution
// is always zero and the first character has no effect on the resulting ID.
// This is a known bug, not intended behavior. It is not fixed here because
// changing MkServiceID is a wire-protocol breaking change (it would alter
// every IPv6 service address and the svcId lookup keys in ServiceNetwork),
// requiring a coordinated upgrade across all peers in a network. Single-char
// service names are not used in practice, so the bug is harmless today.
// This test pins the current (buggy) behavior so any accidental change to
// MkServiceID is caught; fix it together with a protocol version bump.
expected := [2]byte{0xff, 0xfe}
assert.Equal(t, expected, result, "BUG: single-char service ID collides with empty string")
}
func Test_MkServiceID_NonCommutative(t *testing.T) {
id1 := MkServiceID("ab")
id2 := MkServiceID("ba")