From 8f0702c4da91074b9ccdcb81fec6cba979d70a86 Mon Sep 17 00:00:00 2001 From: Abi Raditya Date: Sun, 26 Jul 2026 21:13:26 +0700 Subject: [PATCH] fix(domains): don't render CDN info message as an error in DNS tooltip validateDomain returns isValid: true for CDN-fronted domains but reuses the `error` field to carry the provider's informational warning. Both domain tooltips branched on `error` alone, so the message rendered under a red "Error:" heading even though the badge correctly showed a green "Behind Cloudflare" state. Check the valid+message case first, matching how the badge already distinguishes the two. Applied to both the table view (columns.tsx) and the card view (show-domains.tsx), which shares the same tooltip. Fixes #4910 Co-Authored-By: Claude Opus 5 --- .../components/dashboard/application/domains/columns.tsx | 4 +++- .../dashboard/application/domains/show-domains.tsx | 5 ++++- 2 files changed, 7 insertions(+), 2 deletions(-) diff --git a/apps/dokploy/components/dashboard/application/domains/columns.tsx b/apps/dokploy/components/dashboard/application/domains/columns.tsx index b88443dcc..816fbbb8d 100644 --- a/apps/dokploy/components/dashboard/application/domains/columns.tsx +++ b/apps/dokploy/components/dashboard/application/domains/columns.tsx @@ -209,7 +209,9 @@ export const createColumns = ({ - {validationState?.error ? ( + {validationState?.isValid && validationState?.message ? ( +

{validationState.message}

+ ) : validationState?.error ? (

Error:

{validationState.error}

diff --git a/apps/dokploy/components/dashboard/application/domains/show-domains.tsx b/apps/dokploy/components/dashboard/application/domains/show-domains.tsx index daed0e251..23d9e46bb 100644 --- a/apps/dokploy/components/dashboard/application/domains/show-domains.tsx +++ b/apps/dokploy/components/dashboard/application/domains/show-domains.tsx @@ -626,7 +626,10 @@ export const ShowDomains = ({ id, type }: Props) => { - {validationState?.error ? ( + {validationState?.isValid && + validationState?.message ? ( +

{validationState.message}

+ ) : validationState?.error ? (

Error: