diff --git a/customize.dist/src/less2/include/forms.less b/customize.dist/src/less2/include/forms.less index 3c0b206db..0d00204f0 100644 --- a/customize.dist/src/less2/include/forms.less +++ b/customize.dist/src/less2/include/forms.less @@ -199,6 +199,16 @@ background-color: @cp_buttons-default; } } + &.btn-default-alt { + border-color: @cp_buttons-default; + color: @cp_buttons-default; + background-color: @cp_buttons-default-color; + &:hover, &:not(:disabled):active, &:focus { + border-color: @cp_buttons-default-color; + color: @cp_buttons-default-color; + background-color: @cp_toolbar-fade3; + } + } &.danger, &.btn-danger { background-color: @cp_buttons-red; diff --git a/www/kanban/app-kanban.less b/www/kanban/app-kanban.less index 86e1052b5..ef0fc7fd8 100644 --- a/www/kanban/app-kanban.less +++ b/www/kanban/app-kanban.less @@ -145,6 +145,9 @@ margin-bottom: 15px; } + .cp-kanban-toggle-tags { + margin-right: 0.5rem; + } #cp-kanban-edit-tags { .tokenfield { margin: 0; @@ -152,10 +155,6 @@ } margin-bottom: 15px; } - .kanban-tag-btn-toggle { - margin-top: 10px; - margin-left: 10px - } #cp-app-kanban-container { flex: 1; display: flex; @@ -430,12 +429,10 @@ justify-content: space-between; position: relative; min-height: 50px; + align-items: center; .cp-kanban-filterTags { @media (min-width: 505px) { display: inline-flex; - .kanban-tag-btn-toggle { - margin-right: 10px; - } } align-items: center; flex: 1; @@ -571,7 +568,7 @@ display: flex; min-height: 0; .kanban-container { - padding: 30px 5px; + padding: 0px 5px; flex: 1; display: flex; max-height: 100%; @@ -700,6 +697,15 @@ } } + @media (pointer: none), (pointer:coarse) { + .kanban-container-outer { + .kanban-container { + padding: 30px 5px; + } + } + } + + &.cp-app-readonly { .kanban-item, .kanban-title-board { cursor: default !important; diff --git a/www/kanban/inner.js b/www/kanban/inner.js index 947092c59..502da34ad 100644 --- a/www/kanban/inner.js +++ b/www/kanban/inner.js @@ -930,8 +930,6 @@ define([ //framework._.sfCommon.setPadAttribute('quickMode', false); }); - var toggleTagsButton = h('button.btn.btn-default.kanban-tag-btn-toggle', Messages.kanban_showTags); - // Tags filter var existing = getExistingTags(kanban.options.boards); var list = h('div.cp-kanban-filterTags-list'); @@ -941,7 +939,6 @@ define([ ]); var hint = h('span.cp-kanban-filterTags-name', Messages.kanban_tags); var tags = h('div.cp-kanban-filterTags', [ - h('span.cp-kanban-filterTags-toggle', [ hint, reset, @@ -1022,41 +1019,20 @@ define([ commitTags(); }); + let toggleTagsButton = h('button.btn.btn-default.cp-kanban-toggle-tags', [ + h('i.fa.fa-tags'), + h('span', Messages.fm_tagsName) + ]); - if ($(window).width() < 500) { - - $(tags).append(toggleTagsButton); - - var hideTags = function () { - for (var tag of list.children) { - if (existing.indexOf(tag.innerHTML) > 10) { - $(tag).hide(); - } - } - }; - hideTags(); - - var toggleTags = function () { - for (var tag of list.children) { - if (existing.indexOf(tag.innerHTML) > 10 && kanban.options.tags.indexOf(tag.innerHTML) === -1) { - if ($(tag).is(":visible")) { - $(tag).hide(); - $(toggleTagsButton).text(Messages.kanban_showTags); - } else { - $(tag).show(); - $(toggleTagsButton).text(Messages.kanban_hideTags); - } - } - } - }; - - $(toggleTagsButton).click(function() { - toggleTags(); - }); - - } + let $toggleBtn = $(toggleTagsButton).click(function() { + let $t = $(tags).toggle(); + let visible = $t.is(':visible'); + $toggleBtn.toggleClass('btn-default', visible); + $toggleBtn.toggleClass('btn-default-alt', !visible); + }); var container = h('div#cp-kanban-controls', [ + toggleTagsButton, tags, h('div.cp-kanban-changeView', [ small, @@ -1065,18 +1041,6 @@ define([ ]); $container.before(container); - var common = framework._.sfCommon; - var $button = common.createButton('toggle', true, { - element: $(container), - icon: 'fa-tags', - text: Messages.fm_tagsName, - }, function () { - $button.toggleClass('cp-toolbar-button-active'); - - }); - $button.addClass('cp-toolbar-button-active'); - framework._.toolbar.$bottomL.append($button); - onRedraw.reg(function () { // Redraw if new tags have been added to items var old = Sortify(existing);