From b969a68d78bbb84a459eae9a22b20169fda00fd2 Mon Sep 17 00:00:00 2001
From: yflory <yann.flory@xwiki.com>
Date: Wed, 4 Dec 2024 13:49:23 +0100
Subject: [PATCH] lint compliance

---
 eslint.config.js      |  1 +
 www/admin/inner.js    | 19 +++++++++++--------
 www/common/toolbar.js |  2 +-
 3 files changed, 13 insertions(+), 9 deletions(-)

diff --git a/eslint.config.js b/eslint.config.js
index 6402b0866..eba722d94 100644
--- a/eslint.config.js
+++ b/eslint.config.js
@@ -71,6 +71,7 @@ module.exports = [{
         "no-useless-escape": ["off"],
         "no-extra-boolean-cast": ["off"],
         "no-prototype-builtins": ["off"],
+        "no-use-before-define": ["error"],
         "no-unused-vars": [
             "error",
             {
diff --git a/www/admin/inner.js b/www/admin/inner.js
index c8342a6f7..9153436e5 100644
--- a/www/admin/inner.js
+++ b/www/admin/inner.js
@@ -968,12 +968,7 @@ define([
                 });
             };
 
-            let btn = blocks.activeButton('primary', '',
-              Messages.admin_colorChange, (done) => {
-                let color = $input.val();
-                setColor(color, done);
-            });
-
+            let $input = $();
             let onColorPicked = () => {
                 require(['/lib/less.min.js'], (Less) => {
                     let color = $input.val();
@@ -995,7 +990,14 @@ define([
                     $preview.find('.cp-admin-color-preview-light a').attr('style', `color: ${color} !important`);
                 });
             };
-            let $input = $(input).on('change', onColorPicked).addClass('cp-admin-color-picker');
+            $input = $(input).on('change', onColorPicked).addClass('cp-admin-color-picker');
+
+            let btn = blocks.activeButton('primary', '',
+              Messages.admin_colorChange, (done) => {
+                let color = $input.val();
+                setColor(color, done);
+            });
+
 
             UI.confirmButton($remove, {
                 classes: 'btn-danger',
@@ -3185,6 +3187,7 @@ define([
                 labelEnd,
             ], blocks.nav([button]));
 
+            let send = function () {};
             var refresh = getApi(function (Broadcast) {
                 $active.empty();
                 var removeButton = blocks.button('danger', '', Messages.admin_maintenanceCancel);
@@ -3246,7 +3249,7 @@ define([
                 };
             };
 
-            var send = function (data) {
+            send = function (data) {
                 disable($button);
                 sFrameChan.query('Q_ADMIN_RPC', {
                     cmd: 'ADMIN_DECREE',
diff --git a/www/common/toolbar.js b/www/common/toolbar.js
index 2b0d2f648..e950b3981 100644
--- a/www/common/toolbar.js
+++ b/www/common/toolbar.js
@@ -1416,7 +1416,7 @@ MessengerUI, Messages, Pages, PadTypes) {
 
         tb['pad'] = function () {
             toolbar.$file.show();
-            addElement([
+            toolbar.addElement([
                 'chat',
                 'collapse',
                 'userlist', 'title', 'useradmin', 'spinner',