From e3ee2e58072e3977b19f9adfe0882e57b4f0e296 Mon Sep 17 00:00:00 2001
From: daria <dariae9@yahoo.com>
Date: Mon, 17 Mar 2025 13:13:15 +0200
Subject: [PATCH 1/3] add aria-hidden to icons

---
 www/common/inner/sidebar-layout.js | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/www/common/inner/sidebar-layout.js b/www/common/inner/sidebar-layout.js
index 03ce9c151..a356bffaf 100644
--- a/www/common/inner/sidebar-layout.js
+++ b/www/common/inner/sidebar-layout.js
@@ -64,7 +64,7 @@ define([
                 let prefix = icon.slice(0, icon.indexOf('-'));
                 cls = `.${prefix}.${icon}`;
             }
-            return h(`i${cls}`);
+            return h(`i${cls}`, { 'aria-hidden': 'true' });
         };
         blocks.button = (type, icon, text) => {
             type = type || 'primary';

From dc5a51b2154da7b57d0ed3aa3e47b317cbdbdee6 Mon Sep 17 00:00:00 2001
From: daria <dariae9@yahoo.com>
Date: Mon, 17 Mar 2025 14:11:18 +0200
Subject: [PATCH 2/3] add error messages

---
 customize.dist/messages.js | 2 ++
 www/admin/inner.js         | 7 ++++++-
 2 files changed, 8 insertions(+), 1 deletion(-)

diff --git a/customize.dist/messages.js b/customize.dist/messages.js
index 469279baf..38206fdbf 100755
--- a/customize.dist/messages.js
+++ b/customize.dist/messages.js
@@ -144,6 +144,8 @@ define(req, function(AppConfig, Default, Language) {
         Messages.admin_addAdminsHint = "Add administrators from their public key or from your contacts list";
         Messages.admin_addAdminsAdd = "Promote a contact to admin";
         Messages.admin_addKeyLabel = "Add an admin using their public key";
+        Messages.admin_errorAddKeyLabel = "Add a valid public key";
+        Messages.admin_errorAddAdminsAdd = "Pick a contact to promote to admin";
 
         Messages.admin_listName = "Admin name";
         Messages.admin_listKey = "Admin key";
diff --git a/www/admin/inner.js b/www/admin/inner.js
index 7c0a157d0..7d53ba7a2 100644
--- a/www/admin/inner.js
+++ b/www/admin/inner.js
@@ -346,7 +346,9 @@ define([
             Util.onClickEnter($keyBtn, () => {
                 let val = $keyInput.val().trim();
                 let key = Keys.canonicalize(val);
-                if (!key) { return; }
+                if (!key) {
+                    UI.warn(Messages.admin_errorAddKeyLabel);
+                    return; }
                 // We have a valid key
                 let name = Messages.admin_admin;
                 try {
@@ -388,6 +390,9 @@ define([
                 let addBtn = blocks.button('primary', 'fa-plus', Messages.tag_add);
                 Util.onClickEnter($(addBtn), () => {
                     var $sel = $(contactsGrid.div).find('.cp-usergrid-user.cp-selected');
+                    if (!$sel.length) {
+                        UI.warn(Messages.admin_errorAddAdminsAdd);
+                        return; }
                     nThen((waitFor) => {
                         $sel.each((i, el) => {
                             const $el = $(el);

From bd418f780738040abf535b45ec5c0e6715ddedd6 Mon Sep 17 00:00:00 2001
From: daria <dariae9@yahoo.com>
Date: Mon, 17 Mar 2025 16:10:06 +0200
Subject: [PATCH 3/3] fix error messages

---
 customize.dist/messages.js | 2 +-
 www/admin/inner.js         | 8 ++++----
 2 files changed, 5 insertions(+), 5 deletions(-)

diff --git a/customize.dist/messages.js b/customize.dist/messages.js
index 38206fdbf..e4befa66d 100755
--- a/customize.dist/messages.js
+++ b/customize.dist/messages.js
@@ -145,7 +145,7 @@ define(req, function(AppConfig, Default, Language) {
         Messages.admin_addAdminsAdd = "Promote a contact to admin";
         Messages.admin_addKeyLabel = "Add an admin using their public key";
         Messages.admin_errorAddKeyLabel = "Add a valid public key";
-        Messages.admin_errorAddAdminsAdd = "Pick a contact to promote to admin";
+        Messages.admin_errorAddAdmins = "Pick a contact to promote to admin";
 
         Messages.admin_listName = "Admin name";
         Messages.admin_listKey = "Admin key";
diff --git a/www/admin/inner.js b/www/admin/inner.js
index 7d53ba7a2..9c2b531d7 100644
--- a/www/admin/inner.js
+++ b/www/admin/inner.js
@@ -347,8 +347,8 @@ define([
                 let val = $keyInput.val().trim();
                 let key = Keys.canonicalize(val);
                 if (!key) {
-                    UI.warn(Messages.admin_errorAddKeyLabel);
-                    return; }
+                    return UI.warn(Messages.admin_errorAddKeyLabel);
+                }
                 // We have a valid key
                 let name = Messages.admin_admin;
                 try {
@@ -391,8 +391,8 @@ define([
                 Util.onClickEnter($(addBtn), () => {
                     var $sel = $(contactsGrid.div).find('.cp-usergrid-user.cp-selected');
                     if (!$sel.length) {
-                        UI.warn(Messages.admin_errorAddAdminsAdd);
-                        return; }
+                        return UI.warn(Messages.admin_errorAddAdmins);
+                    }
                     nThen((waitFor) => {
                         $sel.each((i, el) => {
                             const $el = $(el);