From 422b92ba7ae05873d092e8f62984fdbbdf4a54f2 Mon Sep 17 00:00:00 2001 From: daria <95225431+dariiing@users.noreply.github.com> Date: Wed, 26 Mar 2025 13:55:56 +0200 Subject: [PATCH] add tabindex to clickable elements (dismiss notification/s & go to profile link) #1781 --- customize.dist/messages.js | 2 +- www/common/sframe-common-mailbox.js | 11 ++++++++++- www/notifications/inner.js | 7 ++++++- 3 files changed, 17 insertions(+), 3 deletions(-) diff --git a/customize.dist/messages.js b/customize.dist/messages.js index a28190005..467b6dcca 100755 --- a/customize.dist/messages.js +++ b/customize.dist/messages.js @@ -135,7 +135,7 @@ define(req, function(AppConfig, Default, Language) { }; - + Messages.user_profile = 'Go to user profile'; return Messages; }); diff --git a/www/common/sframe-common-mailbox.js b/www/common/sframe-common-mailbox.js index bf05bdd18..9800e6124 100644 --- a/www/common/sframe-common-mailbox.js +++ b/www/common/sframe-common-mailbox.js @@ -81,8 +81,16 @@ define([ Common.openURL(Hash.hashToHref('', 'calendar')); }); } else if (userData && typeof(userData) === "object" && userData.profile) { - avatar = h('span.cp-avatar'); + avatar = h('span.cp-avatar',{ + tabindex: 0, + title: Messages.user_profile + }); Common.displayAvatar($(avatar), userData.avatar, userData.displayName || userData.name); + $(avatar).keydown(function (e) { + if (e.which === 13 || e.which === 32) { + $(avatar).click(); + } + }); $(avatar).click(function (e) { e.stopPropagation(); Common.openURL(Hash.hashToHref(userData.profile, 'profile')); @@ -136,6 +144,7 @@ define([ if (data.content.isDismissible) { var dismissIcon = h('span.fa.fa-times'); var dismiss = h('div.cp-notification-dismiss', { + tabindex: 0, title: Messages.notifications_dismiss, }, dismissIcon); $(dismiss).addClass("cp-clickable") diff --git a/www/notifications/inner.js b/www/notifications/inner.js index 8228f73c5..50eac3b5d 100644 --- a/www/notifications/inner.js +++ b/www/notifications/inner.js @@ -74,7 +74,7 @@ define([ h("h5.cp-app-notifications-panel-title", (Messages.notificationsPage || "Notifications") + " - " + categoryName), h("div.cp-app-notifications-panel-titlebar-buttons", [ - dismissAll = h("div.cp-app-notifications-dismissall.cp-clickable", { title: Messages.notifications_dismissAll || "Dismiss All" }, h("span.fa.fa-trash")), + dismissAll = h("div.cp-app-notifications-dismissall.cp-clickable", { tabindex: 0, title: Messages.notifications_dismissAll || "Dismiss All" }, h("span.fa.fa-trash")), ]), ]), notifsList = h("div.cp-app-notifications-panel-list", [ @@ -154,6 +154,11 @@ define([ } }); + $(dismissAll).keydown(function (e) { + if (e.keyCode === 13 || e.keyCode === 32) { + $(dismissAll).click(); + } + }); $(dismissAll).click(function () { notifsData.forEach(function (data) { if (data.content.isDismissible) {