From 3af8b46b5a9714f40c30848fc033e084eab42844 Mon Sep 17 00:00:00 2001
From: Fabrice Mouhartem <fabrice.mouhartem@xwiki.com>
Date: Wed, 18 Mar 2026 13:36:06 +0100
Subject: [PATCH] refactor(burn after read): remove loop on otherChan

- style: more modern code
---
 www/common/inner/share.js | 26 +++++++++-----------------
 1 file changed, 9 insertions(+), 17 deletions(-)

diff --git a/www/common/inner/share.js b/www/common/inner/share.js
index 77321aab7..f9331c9f7 100644
--- a/www/common/inner/share.js
+++ b/www/common/inner/share.js
@@ -265,36 +265,28 @@ define([
         });
         return teams;
     };
-    var makeBurnAfterReadingUrl = function (common, href, channel, opts, cb) {
-        var keyPair = Hash.generateSignPair();
-        var parsed = Hash.parsePadUrl(href);
-        var newHref = parsed.getUrl({
+    const makeBurnAfterReadingUrl = (common, href, channel, opts, cb) => {
+        const keyPair = Hash.generateSignPair();
+        const parsed = Hash.parsePadUrl(href);
+        const newHref = parsed.getUrl({
             ownerKey: keyPair.safeSignKey
         });
-        var sframeChan = common.getSframeChannel();
+        const sframeChan = common.getSframeChannel();
         const priv = common.getMetadataMgr().getPrivateData();
         const { otherChan } = Modal.getOtherChans(priv, opts);
-        nThen(function (waitFor) {
+        nThen((waitFor) => {
             sframeChan.query('Q_SET_PAD_METADATA', {
                 channel: channel,
+                channels: otherChan,
                 command: 'ADD_OWNERS',
                 value: [keyPair.validateKey]
-            }, waitFor(function (err) {
+            }, waitFor((err) => {
                 if (err) {
                     waitFor.abort();
                     UI.warn(Messages.error);
                 }
             }));
-            otherChan?.forEach((chan) => {
-                sframeChan.query('Q_SET_PAD_METADATA', {
-                    channel: chan,
-                    command: 'ADD_OWNERS',
-                    value: [keyPair.validateKey]
-                }, waitFor(function (err) {
-                    if (err) { console.error(err); }
-                }));
-            });
-        }).nThen(function () {
+        }).nThen(() => {
             cb(newHref);
         });
     };