From 385c0d4d88cdb061f863f6d786e3f2a85264f72e Mon Sep 17 00:00:00 2001 From: ansuz Date: Fri, 16 Sep 2022 18:42:28 +0530 Subject: [PATCH] leave notes about a mobile-user edge-case --- www/common/common-interface.js | 2 +- www/common/common-ui-elements.js | 2 ++ www/common/sframe-common.js | 2 ++ 3 files changed, 5 insertions(+), 1 deletion(-) diff --git a/www/common/common-interface.js b/www/common/common-interface.js index 841eadc63..53c869693 100644 --- a/www/common/common-interface.js +++ b/www/common/common-interface.js @@ -1041,7 +1041,7 @@ define([ }); if (exitable) { $(window).focus(); - $(window).keydown(function (e) { + $(window).keydown(function (e) { // XXX what if they don't have a keyboard? if (e.which === 27) { $loading.hide(); if (typeof(exitable) === "function") { exitable(); } diff --git a/www/common/common-ui-elements.js b/www/common/common-ui-elements.js index 0aca3c9b0..7fce36d96 100644 --- a/www/common/common-ui-elements.js +++ b/www/common/common-ui-elements.js @@ -2820,6 +2820,8 @@ define([ if (err.type === 'EEXPIRED') { msg = Messages.expiredError; if (err.loaded) { + // XXX You can still use the current version in read-only mode by pressing Esc. + // what if they don't have a keyboard (ie. mobile) msg += Messages.errorCopy; } if (toolbar && typeof toolbar.deleted === "function") { toolbar.deleted(); } diff --git a/www/common/sframe-common.js b/www/common/sframe-common.js index a88c973e4..87054a887 100644 --- a/www/common/sframe-common.js +++ b/www/common/sframe-common.js @@ -856,6 +856,8 @@ define([ ctx.sframeChan.on('EV_LOADING_ERROR', function (err) { var msg = err; if (err === 'DELETED') { + // XXX You can still use the current version in read-only mode by pressing Esc. + // what if they don't have a keyboard (ie. mobile) msg = Messages.deletedError + '
' + Messages.errorRedirectToHome; } if (err === "INVALID_HASH") {