From b135e815e7bd353ac7240ecffbdfb904c5cf7711 Mon Sep 17 00:00:00 2001
From: yflory <yann.flory@xwiki.com>
Date: Tue, 14 Jan 2025 18:13:45 +0100
Subject: [PATCH 1/7] Allow new types of decrees in different files

---
 lib/commands/admin-rpc.js |  13 ++
 lib/decrees-core.js       | 141 +++++++++++++++++
 lib/decrees.js            | 324 ++++++++++++--------------------------
 lib/env.js                |   2 +-
 lib/http-worker.js        |  15 +-
 lib/load-config.js        |   7 -
 package-lock.json         |  16 +-
 package.json              |   2 +-
 www/admin/inner.js        |  22 ++-
 9 files changed, 287 insertions(+), 255 deletions(-)
 create mode 100644 lib/decrees-core.js

diff --git a/lib/commands/admin-rpc.js b/lib/commands/admin-rpc.js
index 9030159f8..b682bbf62 100644
--- a/lib/commands/admin-rpc.js
+++ b/lib/commands/admin-rpc.js
@@ -1138,6 +1138,19 @@ Admin.command = function (Env, safeKey, data, _cb, Server) {
 
     var command = commands[data[0]];
 
+    Object.keys(Env.plugins || {}).forEach(name => {
+        let plugin = Env.plugins[name];
+        if (!plugin.addAdminCommands) { return; }
+        try {
+            let c = plugin.addAdminCommands(Env);
+            Object.keys(c || {}).forEach(cmd => {
+                if (typeof(c[cmd]) !== "function") { return; }
+                if (commands[cmd]) { return; }
+                commands[cmd] = c[cmd];
+            });
+        } catch (e) {}
+    });
+
     if (typeof(command) === 'function') {
         return void command(Env, Server, cb, data, unsafeKey);
     }
diff --git a/lib/decrees-core.js b/lib/decrees-core.js
new file mode 100644
index 000000000..a8320a922
--- /dev/null
+++ b/lib/decrees-core.js
@@ -0,0 +1,141 @@
+// SPDX-FileCopyrightText: 2023 XWiki CryptPad Team <contact@cryptpad.org> and contributors
+//
+// SPDX-License-Identifier: AGPL-3.0-or-later
+
+var Decrees = module.exports;
+var Util = require("./common-util");
+var Fs = require("fs");
+var Path = require("path");
+var readFileBin = require("./stream-file").readFileBin;
+var Schedule = require("./schedule");
+var Fse = require("fs-extra");
+var nThen = require("nthen");
+
+
+const Utils = Decrees.Utils = {};
+var isString = (str) => {
+    return typeof(str) === "string";
+};
+var isInteger = function (n) {
+    return !(typeof(n) !== 'number' || isNaN(n) || (n % 1) !== 0);
+};
+Utils.args_isBoolean = function (args) {
+    return !(!Array.isArray(args) || typeof(args[0]) !== 'boolean');
+};
+Utils.args_isString = function (args) {
+    return !(!Array.isArray(args) || !isString(args[0]));
+};
+Utils.args_isInteger = function (args) {
+    return !(!Array.isArray(args) || !isInteger(args[0]));
+};
+Utils.args_isPositiveInteger = function (args) {
+    return Array.isArray(args) && isInteger(args[0]) && args[0] > 0;
+};
+
+
+Decrees.create = (name, commands) => {
+    // [<command>, <args>, <author>, <time>]
+    const handleCommand = function (Env, line) {
+        var command = line[0];
+        var args = line[1];
+
+        if (typeof(commands[command]) !== 'function') {
+            console.log('ici', command, commands);
+            throw new Error("DECREE_UNSUPPORTED_COMMAND");
+        }
+
+        var outcome = commands[command](Env, args);
+        if (outcome) {
+            // trigger Env change event...
+            Env.envUpdated.fire();
+        }
+        return outcome;
+    };
+
+    const createLineHandler = function (Env) {
+        var Log = Env.Log;
+
+        var index = -1;
+
+        return function (err, line) {
+            index++;
+            if (err) {
+                // Log the error and bail out
+                return void Log.error("DECREE_LINE_ERR", {
+                    error: err.message,
+                    index: index,
+                    line: line,
+                });
+            }
+
+            if (Array.isArray(line)) {
+                try {
+                    return void handleCommand(Env, line);
+                } catch (err2) {
+                    return void Log.error("DECREE_COMMAND_ERR", {
+                        error: err2.message,
+                        index: index,
+                        line: line,
+                    });
+                }
+            }
+
+            Log.error("DECREE_HANDLER_WEIRD_LINE", {
+                line: line,
+                index: index,
+            });
+        };
+    };
+
+    const load = function (Env, _cb) {
+        Env.scheduleDecree = Env.scheduleDecree || Schedule();
+
+        var cb = Util.once(Util.mkAsync(function (err) {
+            if (err && err.code !== 'ENOENT') {
+                return void _cb(err);
+            }
+            _cb();
+        }));
+
+        Env.scheduleDecree.blocking('', function (unblock) {
+            var done = Util.once(Util.both(cb, unblock));
+            nThen(function (w) {
+                // ensure that the path to the decree log exists
+                Fse.mkdirp(Env.paths.decree, w(function (err) {
+                    if (!err) { return; }
+                    w.abort();
+                    done(err);
+                }));
+            }).nThen(function () {
+                var decreeName = Path.join(Env.paths.decree, name);
+                var stream = Fs.createReadStream(decreeName, {start: 0});
+                var handler = createLineHandler(Env);
+                readFileBin(stream, function (msgObj, next) {
+                    var text = msgObj.buff.toString('utf8');
+                    try {
+                        handler(void 0, JSON.parse(text));
+                    } catch (err) {
+                        handler(err, text);
+                    }
+                    next();
+                }, function (err) {
+                    done(err);
+                });
+            });
+        });
+    };
+
+    const write = function (Env, decree, _cb) {
+        var path = Path.join(Env.paths.decree, name);
+        Env.scheduleDecree.ordered('', function (next) {
+            var cb = Util.both(Util.mkAsync(_cb), next);
+            Fs.appendFile(path, JSON.stringify(decree) + '\n', cb);
+        });
+    };
+
+    return {
+        handleCommand,
+        load,
+        write
+    };
+};
diff --git a/lib/decrees.js b/lib/decrees.js
index 0124d9d90..bb8ee2bae 100644
--- a/lib/decrees.js
+++ b/lib/decrees.js
@@ -1,9 +1,90 @@
-// SPDX-FileCopyrightText: 2023 XWiki CryptPad Team <contact@cryptpad.org> and contributors
+// SPDX-FileCopyrightText: 2025 XWiki CryptPad Team <contact@cryptpad.org> and contributors
 //
 // SPDX-License-Identifier: AGPL-3.0-or-later
 
-var Decrees = module.exports;
-var Core = require("./commands/core");
+const Core = require("./commands/core");
+const DecreesCore = require("./decrees-core");
+
+const Quota = require("./commands/quota");
+const Keys = require("./keys");
+
+const DECREE_NAME = 'decree.ndjson';
+
+const {
+    args_isBoolean,
+    args_isString,
+    args_isInteger,
+    args_isPositiveInteger
+} = DecreesCore.Utils;
+
+// Toggles a simple boolean
+const makeBooleanSetter = function (attr) {
+    return function (Env, args) {
+        if (!args_isBoolean(args)) {
+            throw new Error('INVALID_ARGS');
+        }
+        var bool = args[0];
+        if (bool === Env[attr]) { return false; }
+        Env[attr] = bool;
+        return true;
+    };
+};
+
+const default_validator = function () { return true; };
+const makeGenericSetter = function (attr, validator) {
+    validator = validator || default_validator;
+    return function (Env, args) {
+        if (!validator(args)) {
+            throw new Error("INVALID_ARGS");
+        }
+        var value = args[0];
+        if (value === Env[attr]) { return false; }
+        Env[attr] = value;
+        return true;
+    };
+};
+
+const makeIntegerSetter = function (attr) {
+    return makeGenericSetter(attr, args_isInteger);
+};
+
+const makeTranslation = function (attr) {
+    return function (Env, args) {
+        if (!Array.isArray(args)) { throw new Error("INVALID_ARGS"); }
+        var value = args[0];
+        var state = Env[attr];
+
+        if (typeof(value) === 'string') {
+            if (state.default === value) { return false; }
+            state.default = value;
+            return true;
+        }
+        if (value && typeof(value) === 'object') {
+            var changed = false;
+            Object.keys(value).forEach(function (lang) {
+                if (state[lang] === value[lang]) { return; }
+                state[lang] = value[lang];
+                changed = true;
+            });
+            return changed;
+        }
+        return false;
+    };
+};
+
+/*  commands have a simple API:
+
+* they receive the global Env and the arguments to be applied
+* if the arguments are invalid the operation will not be applied
+  * the command throws
+* if the arguments are valid but do not result in a change, the operation is redundant.
+  * return false
+* if the arguments are valid and will result in a change, the operation should be applied
+  * apply it
+  * return true to indicate that it was applied
+
+*/
+const commands = {};
 
 /*  Admin decrees which modify global server state
 
@@ -75,33 +156,26 @@ RM_ADMIN_KEY
 
 */
 
-var commands = {};
-/*  commands have a simple API:
-
-* they receive the global Env and the arguments to be applied
-* if the arguments are invalid the operation will not be applied
-  * the command throws
-* if the arguments are valid but do not result in a change, the operation is redundant.
-  * return false
-* if the arguments are valid and will result in a change, the operation should be applied
-  * apply it
-  * return true to indicate that it was applied
-
-*/
-
-var args_isBoolean = function (args) {
-    return !(!Array.isArray(args) || typeof(args[0]) !== 'boolean');
+// Maintenance: Empty string or an object with a start and end time
+const isNumber = function (value) {
+    return typeof(value) === "number" && !isNaN(value);
+};
+const args_isMaintenance = function (args) {
+    return Array.isArray(args) && args[0] &&
+        (args[0] === "" || (isNumber(args[0].end) && isNumber(args[0].start)));
 };
 
-// Toggles a simple boolean
-var makeBooleanSetter = function (attr) {
+// we anticipate that we'll add language-specific surveys in the future
+// whenever that happens we can relax validation a bit to support more formats
+const makeBroadcastSetter = function (attr, validation) {
     return function (Env, args) {
-        if (!args_isBoolean(args)) {
+        if ((validation && !validation(args)) && !args_isString(args)) {
             throw new Error('INVALID_ARGS');
         }
-        var bool = args[0];
-        if (bool === Env[attr]) { return false; }
-        Env[attr] = bool;
+        var str = args[0];
+        if (str === Env[attr]) { return false; }
+        Env[attr] = str;
+        Env.broadcastCache = {};
         return true;
     };
 };
@@ -139,49 +213,6 @@ commands.REMOVE_DONATE_BUTTON = makeBooleanSetter('removeDonateButton');
 // CryptPad_AsyncStore.rpc.send('ADMIN', [ 'ADMIN_DECREE', ['BLOCK_DAILY_CHECK', [true]]], console.log)
 commands.BLOCK_DAILY_CHECK = makeBooleanSetter('blockDailyCheck');
 
-/*
-var isNonNegativeNumber = function (n) {
-    return !(typeof(n) !== 'number' || isNaN(n) || n < 0);
-};
-*/
-
-var default_validator = function () { return true; };
-var makeGenericSetter = function (attr, validator) {
-    validator = validator || default_validator;
-    return function (Env, args) {
-        if (!validator(args)) {
-            throw new Error("INVALID_ARGS");
-        }
-        var value = args[0];
-        if (value === Env[attr]) { return false; }
-        Env[attr] = value;
-        return true;
-    };
-};
-
-var isString = (str) => {
-    return typeof(str) === "string";
-};
-var isInteger = function (n) {
-    return !(typeof(n) !== 'number' || isNaN(n) || (n % 1) !== 0);
-};
-
-var args_isString = function (args) {
-    return !(!Array.isArray(args) || !isString(args[0]));
-};
-
-var args_isInteger = function (args) {
-    return !(!Array.isArray(args) || !isInteger(args[0]));
-};
-
-var makeIntegerSetter = function (attr) {
-    return makeGenericSetter(attr, args_isInteger);
-};
-
-var arg_isPositiveInteger = function (args) {
-    return Array.isArray(args) && isInteger(args[0]) && args[0] > 0;
-};
-
 // CryptPad_AsyncStore.rpc.send('ADMIN', [ 'ADMIN_DECREE', ['SET_LOGO_MIME', ['image/png']]], console.log)
 commands.SET_LOGO_MIME = makeGenericSetter('logoMimeType', args_isString);
 
@@ -192,7 +223,7 @@ commands.SET_ACCENT_COLOR = makeGenericSetter('accentColor', args_isString);
 commands.ENABLE_PROFILING = makeBooleanSetter('enableProfiling');
 
 // CryptPad_AsyncStore.rpc.send('ADMIN', [ 'ADMIN_DECREE', ['SET_PROFILING_WINDOW', [10000]]], console.log)
-commands.SET_PROFILING_WINDOW = makeGenericSetter('profilingWindow', arg_isPositiveInteger);
+commands.SET_PROFILING_WINDOW = makeGenericSetter('profilingWindow', args_isPositiveInteger);
 
 // CryptPad_AsyncStore.rpc.send('ADMIN', [ 'ADMIN_DECREE', ['SET_MAX_UPLOAD_SIZE', [50 * 1024 * 1024]]], console.log)
 commands.SET_MAX_UPLOAD_SIZE = makeIntegerSetter('maxUploadSize');
@@ -246,30 +277,6 @@ commands.SET_SUPPORT_KEYS = function (Env, args) {
 // CryptPad_AsyncStore.rpc.send('ADMIN', [ 'ADMIN_DECREE', ['SET_INSTANCE_PURPOSE', ["development"]]], console.log)
 commands.SET_INSTANCE_PURPOSE = makeGenericSetter('instancePurpose', args_isString);
 
-var makeTranslation = function (attr) {
-    return function (Env, args) {
-        if (!Array.isArray(args)) { throw new Error("INVALID_ARGS"); }
-        var value = args[0];
-        var state = Env[attr];
-
-        if (typeof(value) === 'string') {
-            if (state.default === value) { return false; }
-            state.default = value;
-            return true;
-        }
-        if (value && typeof(value) === 'object') {
-            var changed = false;
-            Object.keys(value).forEach(function (lang) {
-                if (state[lang] === value[lang]) { return; }
-                state[lang] = value[lang];
-                changed = true;
-            });
-            return changed;
-        }
-        return false;
-    };
-};
-
 // CryptPad_AsyncStore.rpc.send('ADMIN', [ 'ADMIN_DECREE', ['SET_INSTANCE_JURISDICTION', ['France']]], console.log)
 // CryptPad_AsyncStore.rpc.send('ADMIN', [ 'ADMIN_DECREE', ['SET_INSTANCE_JURISDICTION', [{default:'France',de:'Frankreich'}]]], console.log)
 commands.SET_INSTANCE_JURISDICTION = makeTranslation('instanceJurisdiction');
@@ -286,30 +293,6 @@ commands.SET_INSTANCE_DESCRIPTION = makeTranslation('instanceDescription');
 // CryptPad_AsyncStore.rpc.send('ADMIN', [ 'ADMIN_DECREE', ['SET_INSTANCE_NOTICE', [{default:'Our hosting costs have increased during the pandemic. Please consider donating!',fr:'Nos coûts d'hébergement ont augmenté pendant la pandémie. Veuillez envisager de faire un don !']]], console.log)
 commands.SET_INSTANCE_NOTICE = makeTranslation('instanceNotice');
 
-// Maintenance: Empty string or an object with a start and end time
-var isNumber = function (value) {
-    return typeof(value) === "number" && !isNaN(value);
-};
-var args_isMaintenance = function (args) {
-    return Array.isArray(args) && args[0] &&
-        (args[0] === "" || (isNumber(args[0].end) && isNumber(args[0].start)));
-};
-
-// we anticipate that we'll add language-specific surveys in the future
-// whenever that happens we can relax validation a bit to support more formats
-var makeBroadcastSetter = function (attr, validation) {
-    return function (Env, args) {
-        if ((validation && !validation(args)) && !args_isString(args)) {
-            throw new Error('INVALID_ARGS');
-        }
-        var str = args[0];
-        if (str === Env[attr]) { return false; }
-        Env[attr] = str;
-        Env.broadcastCache = {};
-        return true;
-    };
-};
-
 // CryptPad_AsyncStore.rpc.send('ADMIN', [ 'ADMIN_DECREE', ['SET_LAST_BROADCAST_HASH', [hash]]], console.log)
 commands.SET_LAST_BROADCAST_HASH = makeBroadcastSetter('lastBroadcastHash');
 
@@ -320,10 +303,6 @@ commands.SET_SURVEY_URL = makeBroadcastSetter('surveyURL');
 // CryptPad_AsyncStore.rpc.send('ADMIN', [ 'ADMIN_DECREE', ['SET_MAINTENANCE', [""]]], console.log)
 commands.SET_MAINTENANCE = makeBroadcastSetter('maintenance', args_isMaintenance);
 
-var Quota = require("./commands/quota");
-var Keys = require("./keys");
-var Util = require("./common-util");
-
 // CryptPad_AsyncStore.rpc.send('ADMIN', [ 'ADMIN_DECREE', ['SET_QUOTA', ['[user@box:3000/VzeS4vP1DF+tXGuq1i50DKYuBL+09Yqy8kGxoUKRzhA=]', { limit: 2 * 1024 * 1024 * 1024, plan: 'buddy', note: "you're welcome" } ] ] ], console.log)
 commands.SET_QUOTA = function (Env, args) {
     if (!Array.isArray(args) || args.length !== 2) {
@@ -406,107 +385,6 @@ commands.SET_BEARER_SECRET = function (Env, args) {
     return true;
 };
 
-// [<command>, <args>, <author>, <time>]
-var handleCommand = Decrees.handleCommand = function (Env, line) {
-    var command = line[0];
-    var args = line[1];
 
-    if (typeof(commands[command]) !== 'function') {
-        throw new Error("DECREE_UNSUPPORTED_COMMAND");
-    }
+module.exports = DecreesCore.create(DECREE_NAME, commands);
 
-    var outcome = commands[command](Env, args);
-    if (outcome) {
-        // trigger Env change event...
-        Env.envUpdated.fire();
-    }
-    return outcome;
-};
-
-Decrees.createLineHandler = function (Env) {
-    var Log = Env.Log;
-
-    var index = -1;
-
-    return function (err, line) {
-        index++;
-        if (err) {
-            // Log the error and bail out
-            return void Log.error("DECREE_LINE_ERR", {
-                error: err.message,
-                index: index,
-                line: line,
-            });
-        }
-
-        if (Array.isArray(line)) {
-            try {
-                return void handleCommand(Env, line);
-            } catch (err2) {
-                return void Log.error("DECREE_COMMAND_ERR", {
-                    error: err2.message,
-                    index: index,
-                    line: line,
-                });
-            }
-        }
-
-        Log.error("DECREE_HANDLER_WEIRD_LINE", {
-            line: line,
-            index: index,
-        });
-    };
-};
-
-var Fs = require("fs");
-var Path = require("path");
-var readFileBin = require("./stream-file").readFileBin;
-var Schedule = require("./schedule");
-var Fse = require("fs-extra");
-var nThen = require("nthen");
-
-Decrees.load = function (Env, _cb) {
-    Env.scheduleDecree = Env.scheduleDecree || Schedule();
-
-    var cb = Util.once(Util.mkAsync(function (err) {
-        if (err && err.code !== 'ENOENT') {
-            return void _cb(err);
-        }
-        _cb();
-    }));
-
-    Env.scheduleDecree.blocking('', function (unblock) {
-        var done = Util.once(Util.both(cb, unblock));
-        nThen(function (w) {
-            // ensure that the path to the decree log exists
-            Fse.mkdirp(Env.paths.decree, w(function (err) {
-                if (!err) { return; }
-                w.abort();
-                done(err);
-            }));
-        }).nThen(function () {
-            var decreeName = Path.join(Env.paths.decree, 'decree.ndjson');
-            var stream = Fs.createReadStream(decreeName, {start: 0});
-            var handler = Decrees.createLineHandler(Env);
-            readFileBin(stream, function (msgObj, next) {
-                var text = msgObj.buff.toString('utf8');
-                try {
-                    handler(void 0, JSON.parse(text));
-                } catch (err) {
-                    handler(err, text);
-                }
-                next();
-            }, function (err) {
-                done(err);
-            });
-        });
-    });
-};
-
-Decrees.write = function (Env, decree, _cb) {
-    var path = Path.join(Env.paths.decree, 'decree.ndjson');
-    Env.scheduleDecree.ordered('', function (next) {
-        var cb = Util.both(Util.mkAsync(_cb), next);
-        Fs.appendFile(path, JSON.stringify(decree) + '\n', cb);
-    });
-};
diff --git a/lib/env.js b/lib/env.js
index d3748750f..45b6aa53a 100644
--- a/lib/env.js
+++ b/lib/env.js
@@ -239,7 +239,7 @@ module.exports.create = function (config) {
         evictionReport: {},
         commandTimers: {},
 
-        sso: config.sso,
+        sso: plugins?.SSO?.config || {},
         enforceMFA: config.enforceMFA,
 
         onlyOffice: {
diff --git a/lib/http-worker.js b/lib/http-worker.js
index 9cb88ada0..dbbdb67e3 100644
--- a/lib/http-worker.js
+++ b/lib/http-worker.js
@@ -584,14 +584,15 @@ var makeRouteCache = function (template, cacheName) {
     };
 };
 
-const ssoList = Env.sso && Env.sso.enabled && Array.isArray(Env.sso.list) &&
-                Env.sso.list.map(function (obj) { return obj.name; }) || [];
-const ssoCfg = (SSOUtils && ssoList.length) ? {
-    force: (Env.sso && Env.sso.enforced && 1) || 0,
-    password: (Env.sso && Env.sso.cpPassword && (Env.sso.forceCpPassword ? 2 : 1)) || 0,
-    list: ssoList
-} : false;
 var serveConfig = makeRouteCache(function () {
+    const ssoList = Env.sso && Env.sso.enabled && Array.isArray(Env.sso.list) &&
+                    Env.sso.list.map(function (obj) { return obj.name; }) || [];
+    const ssoCfg = (SSOUtils && ssoList.length) ? {
+        force: (Env.sso && Env.sso.enforced && 1) || 0,
+        password: (Env.sso && Env.sso.cpPassword && (Env.sso.forceCpPassword ? 2 : 1)) || 0,
+        list: ssoList
+    } : false;
+
     return [
         'define(function(){',
         'return ' + JSON.stringify({
diff --git a/lib/load-config.js b/lib/load-config.js
index 8b35153e8..8962550e5 100644
--- a/lib/load-config.js
+++ b/lib/load-config.js
@@ -46,11 +46,4 @@ if (!isPositiveNumber(config.premiumUploadSize) || config.premiumUploadSize < co
     delete config.premiumUploadSize;
 }
 
-config.sso = {};
-try {
-    config.sso = require("../config/sso");
-} catch (e) {
-    //console.log("SSO config not found");
-}
-
 module.exports = config;
diff --git a/package-lock.json b/package-lock.json
index 4c6655198..afc8370de 100644
--- a/package-lock.json
+++ b/package-lock.json
@@ -45,7 +45,7 @@
         "notp": "^2.0.3",
         "nthen": "0.1.8",
         "open-sans-fontface": "^1.4.0",
-        "openid-client": "^5.4.2",
+        "openid-client": "^5.7.0",
         "pako": "^2.1.0",
         "prompt-confirm": "^2.0.4",
         "pull-stream": "^3.6.1",
@@ -2980,9 +2980,9 @@
       }
     },
     "node_modules/jose": {
-      "version": "4.15.5",
-      "resolved": "https://registry.npmjs.org/jose/-/jose-4.15.5.tgz",
-      "integrity": "sha512-jc7BFxgKPKi94uOvEmzlSWFFe2+vASyXaKUpdQKatWAESU2MWjDfFf0fdfc83CDKcA5QecabZeNLyfhe3yKNkg==",
+      "version": "4.15.9",
+      "resolved": "https://registry.npmjs.org/jose/-/jose-4.15.9.tgz",
+      "integrity": "sha512-1vUQX+IdDMVPj4k8kOxgUqlcK518yluMuGZwqlr44FS1ppZB/5GWh4rZG89erpOBOJjU/OBsnCVFfapsRz6nEA==",
       "funding": {
         "url": "https://github.com/sponsors/panva"
       }
@@ -3727,11 +3727,11 @@
       "integrity": "sha512-d1VXrt1qPScsZnDHbZTOf1SmUnanr3KQgQM6+ye6KoFgrLo8a8mkX/J/ZJ2+w7vf0sCC02lRia5SAiaz0JPEog=="
     },
     "node_modules/openid-client": {
-      "version": "5.6.1",
-      "resolved": "https://registry.npmjs.org/openid-client/-/openid-client-5.6.1.tgz",
-      "integrity": "sha512-PtrWsY+dXg6y8mtMPyL/namZSYVz8pjXz3yJiBNZsEdCnu9miHLB4ELVC85WvneMKo2Rg62Ay7NkuCpM0bgiLQ==",
+      "version": "5.7.1",
+      "resolved": "https://registry.npmjs.org/openid-client/-/openid-client-5.7.1.tgz",
+      "integrity": "sha512-jDBPgSVfTnkIh71Hg9pRvtJc6wTwqjRkN88+gCFtYWrlP4Yx2Dsrow8uPi3qLr/aeymPF3o2+dS+wOpglK04ew==",
       "dependencies": {
-        "jose": "^4.15.1",
+        "jose": "^4.15.9",
         "lru-cache": "^6.0.0",
         "object-hash": "^2.2.0",
         "oidc-token-hash": "^5.0.3"
diff --git a/package.json b/package.json
index 9ddd23123..233ea4769 100644
--- a/package.json
+++ b/package.json
@@ -48,7 +48,7 @@
     "notp": "^2.0.3",
     "nthen": "0.1.8",
     "open-sans-fontface": "^1.4.0",
-    "openid-client": "^5.4.2",
+    "openid-client": "^5.7.1",
     "pako": "^2.1.0",
     "prompt-confirm": "^2.0.4",
     "pull-stream": "^3.6.1",
diff --git a/www/admin/inner.js b/www/admin/inner.js
index 9153436e5..e71be6369 100644
--- a/www/admin/inner.js
+++ b/www/admin/inner.js
@@ -3928,7 +3928,7 @@ define([
 
         // EXTENSION_POINT:ADMIN_ITEM
         let utils = {
-            h, Util, Hash, UIElements
+            $, h, Util, Hash, UIElements, UI, APP
         };
         common.getExtensionsSync('ADMIN_ITEM').forEach(ext => {
             if (!ext || !ext.id || typeof(ext.getContent) !== "function") {
@@ -3952,13 +3952,19 @@ define([
         sidebar.makeLeftside(categories);
     };
     var updateStatus = APP.updateStatus = function (cb) {
-        sFrameChan.query('Q_ADMIN_RPC', {
-            cmd: 'INSTANCE_STATUS',
-        }, function (e, data) {
-            if (e) { console.error(e); return void cb(e); }
-            if (!Array.isArray(data)) { return void cb('EINVAL'); }
-            APP.instanceStatus = data[0];
-            console.log("Status", APP.instanceStatus);
+        nThen(w => {
+            sFrameChan.query('Q_ADMIN_RPC', {
+                cmd: 'INSTANCE_STATUS',
+            }, w(function (e, data) {
+                if (e) { console.error(e); return void cb(e); }
+                if (!Array.isArray(data)) { return void cb('EINVAL'); }
+                APP.instanceStatus = data[0];
+                console.log("Status", APP.instanceStatus);
+            }));
+            require([`/api/config?${+new Date()}`], w(ApiConfig => {
+                APP.instanceConfig = ApiConfig;
+            }));
+        }).nThen(() => {
             cb();
         });
     };

From 7c816f488c8ba0914c7c100b1ffec598c7d48093 Mon Sep 17 00:00:00 2001
From: yflory <yann.flory@xwiki.com>
Date: Wed, 15 Jan 2025 18:41:43 +0100
Subject: [PATCH 2/7] Sidebar layout improvements

---
 .../src/less2/include/sidebar-layout.less     |  6 ++++
 lib/decrees-core.js                           |  1 -
 www/common/inner/sidebar-layout.js            | 36 +++++++++++++++++++
 3 files changed, 42 insertions(+), 1 deletion(-)

diff --git a/customize.dist/src/less2/include/sidebar-layout.less b/customize.dist/src/less2/include/sidebar-layout.less
index 90eb873ef..a665d1318 100644
--- a/customize.dist/src/less2/include/sidebar-layout.less
+++ b/customize.dist/src/less2/include/sidebar-layout.less
@@ -236,6 +236,12 @@
                         margin-bottom: 0;
                     }
                 }
+                .cp-sidebarlayout-description-item {
+                    display: block;
+                    color: @cp_sidebar-hint;
+                    margin-top: @sidebar_base-margin;
+                    margin-bottom: 0;
+                }
                 label.noTitle {
                     display: inline-flex;
                     .fa {
diff --git a/lib/decrees-core.js b/lib/decrees-core.js
index a8320a922..3a40e5d6a 100644
--- a/lib/decrees-core.js
+++ b/lib/decrees-core.js
@@ -40,7 +40,6 @@ Decrees.create = (name, commands) => {
         var args = line[1];
 
         if (typeof(commands[command]) !== 'function') {
-            console.log('ici', command, commands);
             throw new Error("DECREE_UNSUPPORTED_COMMAND");
         }
 
diff --git a/www/common/inner/sidebar-layout.js b/www/common/inner/sidebar-layout.js
index 7af940cd8..03ce9c151 100644
--- a/www/common/inner/sidebar-layout.js
+++ b/www/common/inner/sidebar-layout.js
@@ -156,6 +156,35 @@ define([
             return box;
         };
 
+        // opts.values = { key1:label1, key2:label2 }
+        blocks.radio = (key, state, opts, onChange) => {
+            if (!opts?.values) {
+                return void console.error('NO_VALUES');
+            }
+            let all = Object.keys(opts.values).map(k => {
+                let v = opts.values[k];
+                let r = UI.createRadio(
+                    `cp-${app}-${key}`,
+                    `cp-${app}-${key}-${k}`,
+                    v, state === k, {
+                        input: { value: k },
+                        label: { class: 'noTitle' }
+                    }
+                );
+                if (typeof(onChange) === "function"){
+                    $(r).find('input').on('change', function() {
+                        onChange(k);
+                    });
+                }
+                return r;
+            });
+            let block = h('div.cp-sidebar-flex-block', all);
+            if (opts && opts.spinner) {
+                block.spinner = UI.makeSpinner($(block));
+            }
+            return block;
+        };
+
         blocks.table = function (header, entries) {
             const table = h('table.cp-sidebar-table');
             if (header) {
@@ -255,6 +284,13 @@ define([
             return box;
         };
 
+        blocks.hintItem = (hint, item) => {
+            return blocks.form([
+                h('span.cp-sidebarlayout-description-item', hint),
+                item
+            ]);
+        };
+
         return blocks;
     };
 

From 17aafe1b635be235f78d213a75da4c5c76cb3729 Mon Sep 17 00:00:00 2001
From: yflory <yann.flory@xwiki.com>
Date: Fri, 17 Jan 2025 15:04:54 +0100
Subject: [PATCH 3/7] Fix alignment issue with sidebar-layout

---
 customize.dist/src/less2/include/sidebar-layout.less | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/customize.dist/src/less2/include/sidebar-layout.less b/customize.dist/src/less2/include/sidebar-layout.less
index a665d1318..cf27f8c6b 100644
--- a/customize.dist/src/less2/include/sidebar-layout.less
+++ b/customize.dist/src/less2/include/sidebar-layout.less
@@ -7,6 +7,7 @@
 @import (reference) "/customize/src/less2/include/colortheme-all.less";
 @import (reference) "/customize/src/less2/include/leftside-menu.less";
 @import (reference) "/customize/src/less2/include/browser.less";
+@import (reference) "/customize/src/less2/include/variables.less";
 
 @sidebar_block-width: 25rem;;
 @sidebar_base-margin: 0.5rem;
@@ -214,7 +215,7 @@
                             border-top-left-radius: 0px;
                             border-bottom-left-radius: 0px;
                             border-left: 0px;
-                            height: 40px;
+                            height: @variables_input-height;
                             margin: 0 !important;
                         }
                     }

From 8470937181b2f4f02b33d7188aca8a7d996b2453 Mon Sep 17 00:00:00 2001
From: yflory <yann.flory@xwiki.com>
Date: Fri, 17 Jan 2025 16:00:34 +0100
Subject: [PATCH 4/7] Add admin list decrees

---
 lib/decrees.js | 38 ++++++++++++++++++++++++++++++++++++--
 lib/env.js     |  1 +
 2 files changed, 37 insertions(+), 2 deletions(-)

diff --git a/lib/decrees.js b/lib/decrees.js
index bb8ee2bae..53d47fb49 100644
--- a/lib/decrees.js
+++ b/lib/decrees.js
@@ -366,11 +366,45 @@ commands.ADD_ADMIN_KEY = function (Env, args) {
 
     Env.admins = Env.admins || [];
 
-
     var key = Keys.canonicalize(args[0]);
     if (!key) { throw new Error("INVALID_KEY"); }
-    Env.admins.push(key);
 
+    if (Env.admins.includes(key)) { // Nothing to change
+        return false;
+    }
+
+    Env.admins.push(key);
+    Env.adminsData.push(args[0]);
+    return true;
+};
+commands.RM_ADMIN_KEY = function (Env, args) {
+    if (!Array.isArray(args) || args.length !== 1 || !args[0]) {
+        throw new Error("INVALID_ARGS");
+    }
+
+    const key = Keys.canonicalize(args[0]);
+    if (!key) { throw new Error("INVALID_KEY"); }
+
+    Env.admins = Env.admins || [];
+    if (!Env.admins.includes(key)) { // Nothing to change
+        return false;
+    }
+
+    // NOTE prevent removing config.js hardcoded admin keys
+    if (Array.isArray(config?.adminKeys) && config.adminKeys.includes(key)) {
+        throw new Error("CANT_REMOVE_CONFIG");
+    }
+
+    let idx = Env.admins.indexOk(key);
+    if (idx < 0) { return false; } // should never happen
+
+    if (Env.admins.length === 1) { throw new Error("CANT_REMOVE_LAST_ADMIN"); }
+    Env.admins.splice(idx, 1);
+    Env.adminsData = Env.adminsData.filter(str => {
+        const ed = Keys.canonicalize(str);
+        if (!ed) { return true; }
+        return ed !== key;
+    });
     return true;
 };
 
diff --git a/lib/env.js b/lib/env.js
index 45b6aa53a..280828de2 100644
--- a/lib/env.js
+++ b/lib/env.js
@@ -372,6 +372,7 @@ module.exports.create = function (config) {
         Core.DEFAULT_LIMIT;
 
     try {
+        Env.adminsData = config.adminKeys || [];
         Env.admins = (config.adminKeys || []).map(function (k) {
             try {
                 return Keys.canonicalize(k);

From dd2ac916e63b27edbbf6d6b7b305470a1e96fd94 Mon Sep 17 00:00:00 2001
From: yflory <yann.flory@xwiki.com>
Date: Tue, 21 Jan 2025 17:43:26 +0100
Subject: [PATCH 5/7] Add and remove admins from the UI

---
 customize.dist/messages.js                    |  18 ++
 .../src/less2/include/sidebar-layout.less     |   9 +
 lib/commands/admin-rpc.js                     |  28 ++-
 lib/decrees.js                                |   3 +-
 lib/env.js                                    |   2 +-
 www/admin/app-admin.less                      |   5 +
 www/admin/inner.js                            | 199 +++++++++++++++++-
 7 files changed, 259 insertions(+), 5 deletions(-)

diff --git a/customize.dist/messages.js b/customize.dist/messages.js
index be65e98a9..3c9055f29 100755
--- a/customize.dist/messages.js
+++ b/customize.dist/messages.js
@@ -135,6 +135,24 @@ define(req, function(AppConfig, Default, Language) {
             return text;
         }
     };
+
+        // XXX
+        Messages.admin_cat_admins = "Administrators";
+        Messages.admin_admin = "Admin";
+        Messages.admin_listAdminsTitle = "Current administrators";
+        Messages.admin_listAdminsHint = "View and remove administrators";
+        Messages.admin_addAdminsTitle = "Add administrators";
+        Messages.admin_addAdminsHint = "Add administrators from their public key or from your contacts list";
+        Messages.admin_addAdminsAdd = "Promote a contact to admin";
+        Messages.admin_addKeyLabel = "Add an admin using their public key";
+
+        Messages.admin_listName = "Admin name";
+        Messages.admin_listKey = "Admin key";
+        Messages.admin_listAction = "Remove admin rights";
+
+        Messages.admin_listHardcoded = "Admin added into config.js. Can only be removed by editing the config file.";
+        Messages.admin_listConfirm = "Are you sure you want to remove the admin rights of this user?";
+
     return Messages;
 
 });
diff --git a/customize.dist/src/less2/include/sidebar-layout.less b/customize.dist/src/less2/include/sidebar-layout.less
index cf27f8c6b..33950434c 100644
--- a/customize.dist/src/less2/include/sidebar-layout.less
+++ b/customize.dist/src/less2/include/sidebar-layout.less
@@ -122,6 +122,12 @@
                         flex-flow: column;
                         align-items: baseline;
                     }
+                    .cp-usergrid-container {
+                        margin-bottom: 0px !important;
+                        .cp-usergrid-grid {
+                            margin-bottom: -3px;
+                        }
+                    }
                     label {
                         margin-bottom: 0;
                     }
@@ -129,6 +135,9 @@
                         font-family: inherit;
                         max-width: @sidebar_block-width;
                     }
+                    input:invalid {
+                        border: 1px solid red;
+                    }
                     [type="color"] {
                         width: @sidebar_block-width/5;
                         padding: 3px;
diff --git a/lib/commands/admin-rpc.js b/lib/commands/admin-rpc.js
index b682bbf62..eefb24264 100644
--- a/lib/commands/admin-rpc.js
+++ b/lib/commands/admin-rpc.js
@@ -18,9 +18,11 @@ const MFA = require("../storage/mfa");
 const ArchiveAccount = require('../archive-account');
 const { Worker } = require('node:worker_threads');
 const Fse = require("fs-extra");
-
 const Fs = require("fs");
 
+const config = require("../load-config");
+const Keys = require("../keys");
+
 var Admin = module.exports;
 
 var getFileDescriptorCount = function (Env, server, cb) {
@@ -468,7 +470,29 @@ var setLastEviction = function (Env, Server, cb, data, unsafeKey) {
 };
 
 // CryptPad_AsyncStore.rpc.send('ADMIN', ['INSTANCE_STATUS], console.log)
+const getAdminsData = (Env) => {
+    return Env.adminsData.map(str => {
+        // str is either a full public key or just the ed part
+        const edPublic = Keys.canonicalize(str);
+        const hardcoded = Array.isArray(config?.adminKeys) &&
+                config.adminKeys.some(key => {
+                    return Keys.canonicalize(key) === edPublic;
+                });
+        if (str.length === 44) {
+            return { edPublic, first: true, hardcoded };
+        }
+        let name;
+        try {
+            const parsed = Keys.parseUser(str);
+            name = parsed.user;
+        } catch (e) {}
+        return {
+            edPublic, hardcoded, name
+        };
+    });
+};
 var instanceStatus = function (Env, Server, cb) {
+
     cb(void 0, {
 
         appsToDisable: Env.appsToDisable,
@@ -514,6 +538,8 @@ var instanceStatus = function (Env, Server, cb) {
         instanceName: Env.instanceName,
         instanceNotice: Env.instanceNotice,
         enforceMFA: Env.enforceMFA,
+
+        admins: getAdminsData(Env)
     });
 };
 
diff --git a/lib/decrees.js b/lib/decrees.js
index 53d47fb49..9f2582823 100644
--- a/lib/decrees.js
+++ b/lib/decrees.js
@@ -4,6 +4,7 @@
 
 const Core = require("./commands/core");
 const DecreesCore = require("./decrees-core");
+const config = require('./load-config');
 
 const Quota = require("./commands/quota");
 const Keys = require("./keys");
@@ -395,7 +396,7 @@ commands.RM_ADMIN_KEY = function (Env, args) {
         throw new Error("CANT_REMOVE_CONFIG");
     }
 
-    let idx = Env.admins.indexOk(key);
+    let idx = Env.admins.indexOf(key);
     if (idx < 0) { return false; } // should never happen
 
     if (Env.admins.length === 1) { throw new Error("CANT_REMOVE_LAST_ADMIN"); }
diff --git a/lib/env.js b/lib/env.js
index 280828de2..e1c2ed1b4 100644
--- a/lib/env.js
+++ b/lib/env.js
@@ -372,7 +372,7 @@ module.exports.create = function (config) {
         Core.DEFAULT_LIMIT;
 
     try {
-        Env.adminsData = config.adminKeys || [];
+        Env.adminsData = (config.adminKeys || []).slice();
         Env.admins = (config.adminKeys || []).map(function (k) {
             try {
                 return Keys.canonicalize(k);
diff --git a/www/admin/app-admin.less b/www/admin/app-admin.less
index dfec83a83..d051a6855 100644
--- a/www/admin/app-admin.less
+++ b/www/admin/app-admin.less
@@ -61,6 +61,11 @@
                         }
                     }
                 }
+                &[data-item="add-admins"] {
+                    .cp-sidebar-form:not(:last-child) {
+                        margin-bottom: 1em;
+                    }
+                }
             }
         }
 }
diff --git a/www/admin/inner.js b/www/admin/inner.js
index e71be6369..2a4f6c382 100644
--- a/www/admin/inner.js
+++ b/www/admin/inner.js
@@ -67,7 +67,7 @@ define([
                     'description',
                     'email',
                     'jurisdiction',
-                    'flush-cache'
+                    'flush-cache',
                 ]
             },
             'customize': { // Msg.admin_cat_customize
@@ -77,6 +77,13 @@ define([
                     'color',
                 ]
             },
+            'admins': {
+                icon: 'fa fa-users',
+                content: [
+                    'list-admins',
+                    'add-admins'
+                ]
+            },
             'broadcast' : { // Msg.admin_cat_broadcast
                 icon: 'fa fa-bullhorn',
                 content : [
@@ -94,7 +101,7 @@ define([
                 ]
             },
             'apps': { // Msg.admin_cat_apps
-                icon: 'fa  fa-wrench',
+                icon: 'fa fa-wrench',
                 content: [
                     'apps',
                 ]
@@ -226,6 +233,194 @@ define([
             cb(button);
         });
 
+        const evRefreshAdmins = Util.mkEvent();
+        sidebar.addItem('list-admins', cb => {
+            const metadataMgr = common.getMetadataMgr();
+            const privateData = metadataMgr.getPrivateData();
+
+            const removeAdmin = (edPublic, _cb) => {
+                const cb = Util.mkAsync(_cb);
+                sFrameChan.query('Q_ADMIN_RPC', {
+                    cmd: 'ADMIN_DECREE',
+                    data: ['RM_ADMIN_KEY', [edPublic]]
+                }, function (e, response) {
+                    if (e || response.error) {
+                        UI.warn(Messages.error);
+                        console.error(e, response);
+                        return void cb('ERROR');
+                    }
+                    if (typeof(cb) === "function") { cb(); }
+                });
+            };
+
+            const header = [
+                Messages.admin_listName,
+                Messages.admin_listKey,
+                Messages.admin_listAction
+            ];
+            var list = blocks.table(header, []);
+            list.setAttribute('id', 'cp-admin-table');
+            let div = blocks.block([list]);
+            div.setAttribute('id', 'cp-admin-table-container');
+
+            const refreshTable = () => {
+                const admins = APP.instanceStatus.admins || [];
+                const newRows = admins.map(obj => {
+                    let { name, edPublic, hardcoded } = obj;
+                    name = name || Messages.admin_admin;
+                    let button = blocks.button('danger','fa-ban', Messages.admin_usersRemove);
+                    let $b = $(button);
+                    Util.onClickEnter($b, () => {
+                        $b.prop('disabled', 'disabled');
+                        UI.confirm(Messages.admin_listConfirm, yes => {
+                            if (!yes) { return $b.prop('disabled', false); }
+                            removeAdmin(edPublic, err => {
+                                $b.prop('disabled', false);
+                                if (err) { return; }
+                                APP.updateStatus(function () {
+                                    evRefreshAdmins.fire();
+                                });
+                            });
+                        });
+                    });
+                    let note = Messages.admin_listHardcoded;
+                    let action = hardcoded ? note : button;
+
+                    return [name, edPublic, action];
+                });
+                list.updateContent(newRows);
+            };
+            refreshTable();
+            evRefreshAdmins.reg(() => {
+                refreshTable();
+            });
+
+            cb(div);
+        });
+        sidebar.addItem('add-admins', cb => {
+            const content = blocks.block();
+            const metadataMgr = common.getMetadataMgr();
+            const privateData = metadataMgr.getPrivateData();
+            const $div = $(content);
+
+            const addAdmin = (data, _cb) => {
+                const cb = Util.mkAsync(_cb);
+                const { ed, name } = data;
+                const key = Hash.getPublicSigningKeyString(privateData.origin, name, ed);
+                sFrameChan.query('Q_ADMIN_RPC', {
+                    cmd: 'ADMIN_DECREE',
+                    data: ['ADD_ADMIN_KEY', [key]]
+                }, function (e, response) {
+                    if (e || response.error) {
+                        UI.warn(Messages.error);
+                        console.error(e, response);
+                        return void cb('ERROR');
+                    }
+                    if (typeof(cb) === "function") { cb(); }
+                });
+            };
+
+            const keyInput = blocks.input({
+                placeholder: Messages.admin_accountMetadataPlaceholder
+            });
+            const keyLabel = blocks.labelledInput(Messages.admin_addKeyLabel, keyInput);
+            const keyButton = blocks.button('primary', 'fa-plus', Messages.tag_add);
+            const keyForm = blocks.form([keyLabel], blocks.nav([keyButton]));
+            const $keyInput = $(keyInput).on('input', () => {
+                let val = $keyInput.val().trim();
+                if (!val) {
+                    keyInput.setCustomValidity('');
+                    return;
+                }
+                let key = Keys.canonicalize(val);
+
+                if (keyInput.setCustomValidity) {
+                    if (!key) {
+                        const msg = Messages.admin_invalKey;
+                        keyInput.setCustomValidity(msg);
+                    } else {
+                        keyInput.setCustomValidity('');
+                    }
+                }
+            });
+            const $keyBtn = $(keyButton);
+            Util.onClickEnter($keyBtn, () => {
+                let val = $keyInput.val().trim();
+                let key = Keys.canonicalize(val);
+                if (!key) { return; }
+                // We have a valid key
+                let name = Messages.admin_admin;
+                try {
+                    let parsed = Keys.parseUser(val);
+                    name = parsed.user;
+                } catch (e) {}
+                $keyBtn.prop('disabled', 'disabled');
+                addAdmin({ ed:key, name }, (err) => {
+                    $keyBtn.prop('disabled', false);
+                    if (!err) { $keyInput.val(''); }
+                    // refresh
+                    APP.updateStatus(function () {
+                        evRefreshAdmins.fire();
+                    });
+                });
+            });
+
+            const drawContacts = () => {
+                $div.empty();
+                const members = {};
+                const admins = APP.instanceStatus.admins || [];
+                admins.forEach(obj => {
+                    const { edPublic, name, hardcoded, first } = obj;
+                    members[edPublic] = { name, hardcoded, first };
+                });
+
+                // Remove admins from contacts list
+                const friends = Util.clone(common.getFriends(false));
+                Object.keys(friends).forEach((curve) => {
+                    const ed = friends[curve]?.edPublic;
+                    if (members[ed]) { delete friends[curve]; }
+                });
+                let contactsGrid = UIElements.getUserGrid(Messages.admin_addAdminsAdd, {
+                    common: common,
+                    list: true,
+                    large: true,
+                    data: friends
+                }, function () {});
+                let addBtn = blocks.button('primary', 'fa-plus', Messages.tag_add);
+                Util.onClickEnter($(addBtn), () => {
+                    var $sel = $(contactsGrid.div).find('.cp-usergrid-user.cp-selected');
+                    nThen((waitFor) => {
+                        $sel.each((i, el) => {
+                            const $el = $(el);
+                            let ed = $el.attr('data-ed');
+                            let name = $el.attr('data-name');
+                            if (!ed || !name) {
+                                console.error('Missing data on selected user', el);
+                                return void UI.warn(Messages.error);
+                            }
+                            addAdmin({ed, name}, waitFor());
+                        });
+                    }).nThen(() => {
+                        APP.updateStatus(function () {
+                            evRefreshAdmins.fire();
+                            drawContacts();
+                        });
+                    });
+                });
+                evRefreshAdmins.reg(() => {
+                    drawContacts();
+                });
+
+                const list = blocks.form([
+                    //currentList.div,
+                    contactsGrid.div,
+                ], blocks.nav([addBtn]));
+                $div.append([keyForm, list]);
+            };
+            drawContacts();
+            cb(content);
+        });
+
         var isHex = s => !/[^0-9a-f]/.test(s);
 
         var sframeCommand = function (command, data, cb) {

From 396d77a6e4e78b3f4f31e6b6dfe2ac7c98b706d6 Mon Sep 17 00:00:00 2001
From: yflory <yann.flory@xwiki.com>
Date: Wed, 26 Feb 2025 18:23:24 +0100
Subject: [PATCH 6/7] lint compliance

---
 www/admin/inner.js | 3 ---
 1 file changed, 3 deletions(-)

diff --git a/www/admin/inner.js b/www/admin/inner.js
index 2a4f6c382..b2972dd4f 100644
--- a/www/admin/inner.js
+++ b/www/admin/inner.js
@@ -235,9 +235,6 @@ define([
 
         const evRefreshAdmins = Util.mkEvent();
         sidebar.addItem('list-admins', cb => {
-            const metadataMgr = common.getMetadataMgr();
-            const privateData = metadataMgr.getPrivateData();
-
             const removeAdmin = (edPublic, _cb) => {
                 const cb = Util.mkAsync(_cb);
                 sFrameChan.query('Q_ADMIN_RPC', {

From d5817563f32e82e1162b7a27123f0d987bb7d9f4 Mon Sep 17 00:00:00 2001
From: yflory <yann.flory@xwiki.com>
Date: Wed, 12 Mar 2025 14:46:00 +0100
Subject: [PATCH 7/7] Automatically flush cache when updating admins list

---
 www/admin/inner.js | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/www/admin/inner.js b/www/admin/inner.js
index b2972dd4f..7c0a157d0 100644
--- a/www/admin/inner.js
+++ b/www/admin/inner.js
@@ -275,6 +275,7 @@ define([
                                 $b.prop('disabled', false);
                                 if (err) { return; }
                                 APP.updateStatus(function () {
+                                    flushCache();
                                     evRefreshAdmins.fire();
                                 });
                             });
@@ -314,6 +315,7 @@ define([
                         return void cb('ERROR');
                     }
                     if (typeof(cb) === "function") { cb(); }
+                    flushCache();
                 });
             };