mirror of
https://github.com/RetroShare/RetroShare.git
synced 2026-09-12 19:50:17 +05:00
d1785479c8
Reply to G10h4ck's second review pass on the CMake migration PR. - FeedReader: revert the waitForToken interface->helper rename. libretroshare defines WIN32_LEAN_AND_MEAN PUBLIC, inherited by the plugin on Windows, so <windows.h> no longer pulls in the "interface" macro; the rename is unneeded. - retroshare-gui: name the GUI executable "retroshare-gui" on all platforms (RUNTIME_OUTPUT_NAME); clarify that the TARGET define is the single-instance socket name, not the executable name. - retroshare-gui: gate -Wno-deprecated(-declarations) behind a new RS_WARN_DEPRECATED option, mirroring libretroshare. - retroshare-gui: document direct deps (sam3, X11/XScreenSaver idle detection, _FILE_OFFSET_BITS) and the librnp-transitive deps (botan, json-c, z, bz2). - root: move the global Windows UNICODE/_UNICODE definition and the GCC>=15 error downgrade out of the global scope into per-target settings (bitdht, and the legacy C submodules), applied after the subdirectories are added. - root: document why the sam3 target is defined once at the top level. - deploy-macos.sh / deploy-windows.sh: keep them (deployment is a first-class step), document why the macdeployqt/windeployqt glue is needed, and update the bundle/executable names for the rename (retroshare-gui). - Stop tracking the convenience Makefile and build_retroshare.sh (CMake builds everything itself); they remain available locally as untracked files. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> |
||
|---|---|---|
| .. | ||
| Common | ||
| FeedReader | ||
| VOIP | ||
| CMakeLists.txt | ||
| PluginInterface.h | ||
| plugins.pro | ||