The self-view preview in Preferences/VOIP scaled camera frames into the
display widget with Qt::IgnoreAspectRatio, forcing them into a 4:3 box.
Non-4:3 cameras (e.g. 16:9) were therefore stretched vertically.
Use Qt::KeepAspectRatio, matching the sibling showFrameOff() which
already scales the placeholder icon correctly.
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Reply to the build-system review on the CMake migration PR.
CMake:
- retroshare-gui: bump project version 0.6.6 -> 0.6.7; restore
CMAKE_VERBOSE_MAKEFILE ON for development builds; reword
RS_USE_NATIVE_DIALOGS description without referring to qmake; document
why AUTOUIC is OFF and why the qmake_info.h shim exists.
- retroshare-gui: fix circles option name mismatch (if(RS_GXS_CIRCLES) ->
if(RS_GXSCIRCLES)) so RS_USE_CIRCLES is actually defined.
- VOIP, friendserver: drop OpenSSL (and ZLIB/BZip2 for friendserver) which
are not used directly and come transitively through libretroshare; keep
ws2_32 for the friendserver (direct Winsock use in network.cc) and drop
winmm/iphlpapi/mswsock.
- FeedReader: document OpenSSL as a direct dependency and the Windows-only
plugin link requirement.
- VOIP: document __STDC_CONSTANT_MACROS (required by the libav headers).
Source (kept, now with justifying comments; required to build cross-platform):
- p3FeedReader: parameter renamed interface -> helper ("interface" is a
reserved Windows SDK macro).
- PluginsPage, PluginManager, PluginManagerWidget, GxsGroupDialog: compile
fixes exposed by the modular build.
Reverted unrelated cosmetic renames (back to master, dropped from the PR):
- MessageComposer.cpp (grp2), RsNetUtil.cpp (lst2).
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Avoid the need of dirty patching to set the version at build time
In case RS version is not passed as argument attempt to determine it
using git describe, if unavailable use hardcoded default
- Updated external libraries
- Added compile of plugins to build.bat
- Added copy of Qt style DLL to pack.bat and Windows Installer
- Removed "CONFIG=console" for release build