From e3c75aed62df796b0c6a3b40db8b589e8c5223d5 Mon Sep 17 00:00:00 2001 From: jolavillette Date: Thu, 21 May 2026 04:08:58 +0200 Subject: [PATCH] build: scope compile options to targets, fix cmark detection bug --- retroshare-gui/CMakeLists.txt | 8 ++++---- retroshare-service/CMakeLists.txt | 2 +- 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/retroshare-gui/CMakeLists.txt b/retroshare-gui/CMakeLists.txt index a22c800ab..652469818 100644 --- a/retroshare-gui/CMakeLists.txt +++ b/retroshare-gui/CMakeLists.txt @@ -233,9 +233,9 @@ endif(RS_WEBUI) if(RS_GUI_CMARK) set(CMARK_DEVEL_DIR "${CMAKE_CURRENT_SOURCE_DIR}/../supportlibs/cmark/") - if(EXISTS "${LIBRETROSHARE_DEVEL_DIR}/.git" ) - message( STATUS "cmark submodule found at ${LIBRETROSHARE_DEVEL_DIR} using it" ) - add_subdirectory( "${LIBRETROSHARE_DEVEL_DIR}" "${CMAKE_BINARY_DIR}/cmark" ) + if(EXISTS "${CMARK_DEVEL_DIR}/CMakeLists.txt" ) + message( STATUS "cmark submodule found at ${CMARK_DEVEL_DIR} using it" ) + add_subdirectory( "${CMARK_DEVEL_DIR}" "${CMAKE_BINARY_DIR}/cmark" ) else() FetchContent_Declare( cmark @@ -519,7 +519,7 @@ target_link_libraries(${PROJECT_NAME} PRIVATE ${RS_LINK_LIBRARIES}) target_include_directories(${PROJECT_NAME} PRIVATE ${CMAKE_CURRENT_SOURCE_DIR}/src/) -set( CMAKE_CXX_FLAGS "-Wno-deprecated-declarations" ) +target_compile_options(${PROJECT_NAME} PRIVATE -Wno-deprecated-declarations) target_compile_definitions(${PROJECT_NAME} PUBLIC RS_NO_WARN_DEPRECATED ) target_compile_definitions(${PROJECT_NAME} PRIVATE RS_RELEASE_VERSION ) target_compile_definitions(${PROJECT_NAME} PRIVATE TARGET=\"retroshare\") diff --git a/retroshare-service/CMakeLists.txt b/retroshare-service/CMakeLists.txt index 5a3568dc6..2ac8cb90a 100644 --- a/retroshare-service/CMakeLists.txt +++ b/retroshare-service/CMakeLists.txt @@ -30,7 +30,7 @@ option( option( RS_RNPLIB "Enable use RNP lib for PGP" - OFF ) + ON ) option( RS_JSON_API