The_Great_Archive/RetroShare
1
0
Fork 0
mirror of https://github.com/RetroShare/RetroShare.git synced 2026-09-14 11:06:01 +05:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #3151 from jolavillette/FixCrashInTurtleRouterDialog

Browse Source 
fix dangling pointer crash in TurtleRouterDialog by nullifying top_level pointers in hideEvent
This commit is contained in:
csoler 2026-02-07 17:41:52 +01:00 committed by GitHub
commit e04d2c2fc3
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 15 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

15
retroshare-gui/src/gui/statistics/TurtleRouterDialog.cpp
View File

@ -204,6 +204,9 @@ void TurtleRouterDialog::hideEvent(QHideEvent *event)
{
// Clear tree widgets to save memory (Cyril's recommendation)
_f2f_TW->clear();
top_level_s_requests = nullptr;
top_level_t_requests = nullptr;
tunnels_treeWidget->clear();
top_level_hashes.clear();
@ -252,6 +255,18 @@ void TurtleRouterDialog::updateTunnelRequests( const std::vector<std::vector<std
const std::vector<TurtleSearchRequestDisplayInfo >& search_reqs_info,
const std::vector<TurtleTunnelRequestDisplayInfo >& tunnel_reqs_info)
{
// Restore top level items if they were deleted (e.g. in hideEvent)
if (!top_level_s_requests)
{
QStringList stl;
stl.push_back(tr("Search requests"));
top_level_s_requests = new TurtleTreeWidgetItem(_f2f_TW, stl);
stl.clear();
stl.push_back(tr("Tunnel requests"));
top_level_t_requests = new TurtleTreeWidgetItem(_f2f_TW, stl);
}
// Disable sorting during updates to avoid O(N^2 log N) complexity
bool sort_f2f = _f2f_TW->isSortingEnabled();
bool sort_tunnels = tunnels_treeWidget->isSortingEnabled();