From 765a398659598498aeb0ec6bb0d3a1edf95bec43 Mon Sep 17 00:00:00 2001 From: jolavillette Date: Thu, 21 May 2026 14:04:57 +0200 Subject: [PATCH] win32: fix plugin compilation by enabling exports on GUI and linking plugins privately to retroshare and retroshare-gui on Windows --- plugins/FeedReader/CMakeLists.txt | 2 +- plugins/VOIP/CMakeLists.txt | 3 +++ retroshare-gui/CMakeLists.txt | 6 ++++++ 3 files changed, 10 insertions(+), 1 deletion(-) diff --git a/plugins/FeedReader/CMakeLists.txt b/plugins/FeedReader/CMakeLists.txt index 563dcb31f..1f1e57675 100644 --- a/plugins/FeedReader/CMakeLists.txt +++ b/plugins/FeedReader/CMakeLists.txt @@ -95,7 +95,7 @@ set_target_properties(FeedReader PROPERTIES # --- Links --- if(WIN32) - target_link_libraries(FeedReader PRIVATE retroshare) + target_link_libraries(FeedReader PRIVATE retroshare retroshare-gui) endif() target_link_libraries(FeedReader PRIVATE diff --git a/plugins/VOIP/CMakeLists.txt b/plugins/VOIP/CMakeLists.txt index e86385649..d58e7fca7 100644 --- a/plugins/VOIP/CMakeLists.txt +++ b/plugins/VOIP/CMakeLists.txt @@ -91,6 +91,9 @@ set_target_properties(VOIP PROPERTIES target_compile_definitions(VOIP PRIVATE __STDC_CONSTANT_MACROS) # --- Links --- +if(WIN32) + target_link_libraries(VOIP PRIVATE retroshare retroshare-gui) +endif() target_link_libraries(VOIP PRIVATE Qt5::Core diff --git a/retroshare-gui/CMakeLists.txt b/retroshare-gui/CMakeLists.txt index ec619cb37..a5585f0a3 100644 --- a/retroshare-gui/CMakeLists.txt +++ b/retroshare-gui/CMakeLists.txt @@ -134,6 +134,12 @@ file(WRITE "${CMAKE_CURRENT_BINARY_DIR}/include/qmake_info.h" add_executable(${PROJECT_NAME} ${RS_GUI_SOURCES} ${RS_IMPLEMENTATION_HEADERS} ${RS_UI_HEADERS} ${RS_GUI_QTRESOURCES}) set_target_properties(${PROJECT_NAME} PROPERTIES OUTPUT_NAME "retroshare") +if(WIN32) + set_target_properties(${PROJECT_NAME} PROPERTIES + ENABLE_EXPORTS ON + WINDOWS_EXPORT_ALL_SYMBOLS ON + ) +endif() install(TARGETS ${PROJECT_NAME} DESTINATION ${RS_BIN_INSTALL_DIR}) target_link_directories(${PROJECT_NAME} PRIVATE