mirror of
https://github.com/ArchiveBox/ArchiveBox.git
synced 2026-09-12 19:50:57 +05:00
e26a0f6fc0
Multiple hooks in the same plugin directory were overwriting each
other's stdout.log, stderr.log, hook.pid, and cmd.sh files. Now each
hook uses filenames prefixed with its hook name:
- on_Snapshot__20_chrome_tab.bg.stdout.log
- on_Snapshot__20_chrome_tab.bg.stderr.log
- on_Snapshot__20_chrome_tab.bg.pid
- on_Snapshot__20_chrome_tab.bg.sh
Updated:
- hooks.py run_hook() to use hook-specific names
- core/models.py cleanup and update_from_output methods
- Plugin scripts to no longer write redundant hook.pid files
<!-- IMPORTANT: Do not submit PRs with only formatting / PEP8 / line
length changes. -->
# Summary
<!--e.g. This PR fixes ABC or adds the ability to do XYZ...-->
# Related issues
<!-- e.g. #123 or Roadmap goal #
https://github.com/pirate/ArchiveBox/wiki/Roadmap -->
# Changes these areas
- [ ] Bugfixes
- [ ] Feature behavior
- [ ] Command line interface
- [ ] Configuration options
- [ ] Internal architecture
- [ ] Snapshot data layout on disk
<!-- This is an auto-generated description by cubic. -->
---
## Summary by cubic
Prevented hook file collisions by giving each hook its own stdout,
stderr, pid, and cmd filenames. This fixes mixed logs and ensures
correct cleanup and status checks when multiple hooks run in the same
plugin directory.
- **Bug Fixes**
- hooks.py: write hook-specific stdout/stderr/pid/cmd files and exclude
them from new_files; derive cmd.sh from pid for safe kill.
- core/models.py: read hook-specific logs; exclude hook output files
when computing outputs; cleanup and background detection use *.pid.
- Plugins: stop writing redundant hook.pid files; minor chrome utils
cleanup.
<sup>Written for commit
|
||
|---|---|---|
| .. | ||
| accessibility | ||
| apt | ||
| archive_org | ||
| brew | ||
| chrome | ||
| consolelog | ||
| custom | ||
| dom | ||
| env | ||
| favicon | ||
| forumdl | ||
| gallerydl | ||
| git | ||
| headers | ||
| htmltotext | ||
| infiniscroll | ||
| istilldontcareaboutcookies | ||
| mercury | ||
| merkletree | ||
| modalcloser | ||
| npm | ||
| papersdl | ||
| parse_dom_outlinks | ||
| parse_html_urls | ||
| parse_jsonl_urls | ||
| parse_netscape_urls | ||
| parse_rss_urls | ||
| parse_txt_urls | ||
| pip | ||
| readability | ||
| redirects | ||
| responses | ||
| screenshot | ||
| search_backend_ripgrep | ||
| search_backend_sonic | ||
| search_backend_sqlite | ||
| seo | ||
| singlefile | ||
| ssl | ||
| staticfile | ||
| title | ||
| twocaptcha | ||
| ublock | ||
| wget | ||
| ytdlp | ||